Skip to content

fix(@angular-devkit/build-angular): update babel to 7.8.7 #17267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 21, 2020

Babel versions 7.8.0-7.8.6 contain a defect that can cause failures due to babel plugin changes (even in patch versions). Plugins are not pinned as they are deep transitive dependencies of the packages adjusted in this commit. This failure will prevent a newly generated project from building and can only be worked around by disabling differential loading.

Fixes: #17262

NOTE TO CARETAKER: pending status of ci/angular: merge status is incorrect and can be ignored. The two missing status checks do not exist on this branch.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 23, 2020
@ngbot
Copy link

ngbot bot commented Mar 23, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: e2e-cli" is failing
    failure status "ci/circleci: e2e-cli-ivy" is failing
    failure status "ci/circleci: test-win" is failing
    pending missing required status "ci/circleci: test-large-ve"
    pending missing required status "ci/circleci: e2e-cli-ve"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

clydin and others added 2 commits March 23, 2020 14:47
Babel versions 7.8.0-7.8.6 contain a defect that can cause failures due to babel plugin changes (even in patch versions).  Plugins are not pinned as they are transitive dependencies of the packages adjusted in this commit.  This failure will prevent a newly generated project from building and can only be worked around by disabling differential loading.

Fixes: angular#17262
…for default browserslist configuration

(cherry picked from commit e414d9b)
@clydin clydin force-pushed the 8.3.x-update-babel branch from b932cbf to d8d6d18 Compare March 23, 2020 19:20
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@alan-agius4
Copy link
Collaborator

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@clydin clydin added the target: lts This PR is targeting a version currently in long-term support label Mar 23, 2020
@dgp1130 dgp1130 merged commit b260a74 into angular:8.3.x Mar 24, 2020
@clydin clydin deleted the 8.3.x-update-babel branch March 24, 2020 19:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants