Skip to content

feat(@schematics/angular): evergreen new applications #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

feat(@schematics/angular): evergreen new applications #17361

merged 1 commit into from
May 4, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Apr 1, 2020

By default, we now generate new applications which support only evergreen browsers, as a result differential loading is now opt-in.

A new flag --legacy-browsers, was added to generate applications which support non evergreen browsers such as Internet Explorer 11.

Note: After an application is generated opting in and out of differential loading is still possible through the supported browsers configuration in the browserslist configuration file defaulted to .browserslistrc.

Upcoming others PRs

  • Docs will be updated in a separate PR in Angular/Angular TOOL-1370

Reference TOOL-1364

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Apr 2, 2020
@alan-agius4 alan-agius4 requested a review from clydin April 2, 2020 09:27
@alan-agius4 alan-agius4 marked this pull request as ready for review April 2, 2020 09:46
@alan-agius4 alan-agius4 added this to the V10-candidates milestone Apr 2, 2020
@alan-agius4 alan-agius4 requested a review from IgorMinar April 6, 2020 10:04
@alan-agius4 alan-agius4 marked this pull request as draft April 21, 2020 12:14
@alan-agius4 alan-agius4 requested a review from clydin April 22, 2020 07:57
@alan-agius4 alan-agius4 marked this pull request as ready for review April 22, 2020 07:57
@alan-agius4
Copy link
Collaborator Author

Blocking until we get more information from @atscott about dropping IE9-10 support in FW.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall except for the suggestion I made to decouple this change from the IE9/10 decision.

By default, we now generate new applications which support only evergreen browsers, as a result differential loading is now opt-in.

A new flag `--legacy-browsers`, was added to generate applications which support non evergreen browsers such as Internet Explorer 11.

**Note**: After an application is generated opting in and out of differential loading is still possible through the supported browsers configuration in the browserslist configuration file  defaulted to `.browserslistrc`.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 3, 2020
@dgp1130 dgp1130 merged commit a723af4 into angular:master May 4, 2020
@alan-agius4 alan-agius4 deleted the evergreen-browsers-default branch May 4, 2020 18:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants