feat(@schematics/angular): enable stricter type checking and optimization effective coding rules #17372

alan-agius4 · 2020-04-02T11:59:33Z

With this change we enable stricter type checking and optimization effective coding rules when using the --strict option.

Changes in schematics

ng-new: A prompt for the strict option was added. This option is a proxy and will be passed to the application and workspace schematics.
application: A package.json was added in the app folder, to tell the bundlers whether the application is free from side-effect code. When strict is true. the sideEffects will be set false.
workspace When strict is true, we add stricter TypeScript and Angular type-checking options.

Note: AIO is already using these strict TypeScript compiler settings. PR to enable strictTemplates angular/angular#36391

Reference: TOOL-1366

packages/schematics/angular/workspace/files/tsconfig.json.template

packages/schematics/angular/workspace/schema.json

packages/schematics/angular/application/other-files/package.json.template

IgorMinar

other than the nits I posted, this looks good overall.

Please resolve the comments.

@kyliau can you please add these changes to the list of changes we'll want the Docs and DevRel team to carefully review - I'd like them to review all changes to "strings" that are displayed to the user either as prompts, config file / schema comments/docs, or comments in generated files that end up in user workspace. thanks!

packages/schematics/angular/application/other-files/package.json.template

packages/schematics/angular/ng-new/schema.json

IgorMinar · 2020-05-04T19:40:45Z

packages/schematics/angular/workspace/files/tsconfig.json.template

    "noFallthroughCasesInSwitch": true,
-    "strictNullChecks": true,<% } %>
+    "strictPropertyInitialization": false,<% } %>


why? Is this because of @components with @inputs?

I do think that developer's should provide a default value. That's what I do and it works quite well.

I recommend removing this line.

Yeah that’s the reason.

I’ll also do a PR In AIO to remove that.

So for AIO, we better do a followup task, as there a quite a lot of errors when I removed "strictPropertyInitialization": false

packages/schematics/angular/workspace/files/tsconfig.json.template

packages/schematics/angular/ng-new/schema.json

packages/schematics/angular/workspace/schema.json

IgorMinar

oh.. @alan-agius4 one more thing.. weren't we supposed to decrease the budget limits in the --strict mode as well? was that skipped intentionally? Is that in a separate PR? thanks

alan-agius4 · 2020-05-04T20:14:29Z

@IgorMinar, yes I skipped that intentionally as I wanted to follow up with a couple of other PRs to address the bundle budgets and module target.

IgorMinar · 2020-05-05T02:46:22Z

@alan-agius4 ok. Sgtm

alan-agius4 · 2020-05-05T08:48:56Z

@IgorMinar, FYI I actually pushed the budget change in the PR.

IgorMinar

Almost there!

packages/schematics/angular/application/index.ts

packages/schematics/angular/workspace/schema.json

IgorMinar

looks great now! let's get this puppy in! thank you!

dgp1130 · 2020-05-05T18:04:38Z

@alan-agius4, looks like this was the unlucky one again that hit a merge conflict today.

…tion effective coding rules With this change we enable stricter type checking and optimization effective coding rules when using the `--strict` option. Changes in schematics - `ng-new`: A prompt for the `--strict` option was added. This option is a proxy and will be passed to the application and workspace schematics. - `application`: A `package.json` was added in the `app` folder, to tell the bundlers whether the application is free from side-effect code. When `strict` is `true`. the `sideEffects` will be set `false`. - `workspace` When `strict` is true, we add stricter TypeScript and Angular type-checking options. Note: AIO is already using these strict TypeScript compiler settings. PR to enable `strictTemplates` angular/angular#36391 Reference: TOOL-1366

… `--strict` option When using the strict option `anyComponentStyle` and `initial` budgets are more strict.

alan-agius4 · 2020-05-05T18:10:43Z

@dgp1130, conflict solved.

angular-automatic-lock-bot · 2020-06-05T08:05:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 2, 2020

alan-agius4 mentioned this pull request Apr 2, 2020

build: enable strictTemplates in AIO angular/angular#36391

Closed

alan-agius4 added the target: major This PR is targeted for the next major release label Apr 2, 2020

alan-agius4 added this to the V10-candidates milestone Apr 2, 2020

alan-agius4 closed this Apr 2, 2020

alan-agius4 reopened this Apr 2, 2020

alan-agius4 marked this pull request as ready for review April 2, 2020 16:35

alan-agius4 requested review from clydin and IgorMinar April 2, 2020 16:35

clydin reviewed Apr 2, 2020

View reviewed changes

packages/schematics/angular/workspace/files/tsconfig.json.template Show resolved Hide resolved

clydin requested changes Apr 2, 2020

View reviewed changes

packages/schematics/angular/workspace/files/tsconfig.json.template Outdated Show resolved Hide resolved

packages/schematics/angular/workspace/schema.json Outdated Show resolved Hide resolved

alan-agius4 requested a review from clydin April 3, 2020 08:09

clydin approved these changes Apr 6, 2020

View reviewed changes

alan-agius4 added the PR state: blocked label Apr 6, 2020

IgorMinar suggested changes Apr 6, 2020

View reviewed changes

packages/schematics/angular/workspace/schema.json Outdated Show resolved Hide resolved

alan-agius4 marked this pull request as draft April 21, 2020 13:14

alan-agius4 changed the title ~~feat(@schematics/angular): enable strict workspaces by default~~ feat(@schematics/angular): enable stricter type checking and optimization effective coding rules Apr 22, 2020

alan-agius4 removed the PR state: blocked label Apr 22, 2020

alan-agius4 requested review from IgorMinar and clydin April 22, 2020 11:52

alan-agius4 marked this pull request as ready for review April 22, 2020 11:52

alan-agius4 added target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release labels Apr 30, 2020

alan-agius4 mentioned this pull request May 1, 2020

Modern defaults when creating new angular application with strict flag #17589

Closed

15 tasks

clydin reviewed May 4, 2020

View reviewed changes

packages/schematics/angular/application/other-files/package.json.template Show resolved Hide resolved

IgorMinar approved these changes May 4, 2020

View reviewed changes

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 4, 2020

IgorMinar reviewed May 4, 2020

View reviewed changes

alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 5, 2020

IgorMinar reviewed May 5, 2020

View reviewed changes

packages/schematics/angular/application/index.ts Outdated Show resolved Hide resolved

packages/schematics/angular/workspace/schema.json Show resolved Hide resolved

IgorMinar approved these changes May 5, 2020

View reviewed changes

alan-agius4 added 2 commits May 5, 2020 20:10

feat(@schematics/angular): add stricter bundle budgets when using the…

cb9477c

… `--strict` option When using the strict option `anyComponentStyle` and `initial` budgets are more strict.

dgp1130 merged commit a7cf22c into angular:master May 5, 2020

alan-agius4 deleted the strict-workspaces branch May 5, 2020 18:51

alan-agius4 mentioned this pull request May 7, 2020

Make AIO content strictPropertyInitialization compliant angular/angular#36978

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 5, 2020

feat(@schematics/angular): enable stricter type checking and optimization effective coding rules #17372

feat(@schematics/angular): enable stricter type checking and optimization effective coding rules #17372

Uh oh!

Conversation

alan-agius4 commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IgorMinar May 4, 2020

Choose a reason for hiding this comment

Uh oh!

alan-agius4 May 4, 2020

Choose a reason for hiding this comment

Uh oh!

alan-agius4 May 5, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

alan-agius4 commented May 4, 2020

Uh oh!

IgorMinar commented May 5, 2020

Uh oh!

alan-agius4 commented May 5, 2020

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

dgp1130 commented May 5, 2020

Uh oh!

alan-agius4 commented May 5, 2020

Uh oh!

angular-automatic-lock-bot bot commented Jun 5, 2020

Uh oh!

Uh oh!

alan-agius4 commented Apr 2, 2020 •

edited

Loading