Skip to content

refactor(@schematic/angular): remove deprecated options from app-shell and universal schematics #17635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020
Merged

refactor(@schematic/angular): remove deprecated options from app-shell and universal schematics #17635

merged 1 commit into from
May 6, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented May 5, 2020

BREAKING CHANGE: The below options have been removed as they had no effect:

  • test and testTsconfigFileName have been removed form the universal schematic
  • universalProject, name, outDir, root and index have been removed from the app-shell schematic

…ll and universal schematics

BREAKING CHANGE:  The below options have been removed as they had no effect
- `test` and `testTsconfigFileName` have been removed form the universal schematic
- `universalProject`, `name`, `outDir`, `root` and `index` have been removed from the app-shell schematic
@alan-agius4 alan-agius4 self-assigned this May 5, 2020
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label May 5, 2020
@alan-agius4 alan-agius4 removed their assignment May 5, 2020
@alan-agius4 alan-agius4 requested a review from clydin May 5, 2020 13:57
@alan-agius4 alan-agius4 added this to the V10-candidates milestone May 5, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 5, 2020
@dgp1130 dgp1130 merged commit ac3aff2 into angular:master May 6, 2020
@alan-agius4 alan-agius4 deleted the schematic-deprecation branch May 6, 2020 18:48
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants