Skip to content

Conversation

guiseek
Copy link
Contributor

@guiseek guiseek commented Dec 1, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Dec 2, 2024
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 2, 2024
@alan-agius4 alan-agius4 merged commit af87780 into angular:main Dec 2, 2024
35 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.0.x

alan-agius4 pushed a commit that referenced this pull request Dec 2, 2024
…29004)

Add missing required generic type in spec file template.

(cherry picked from commit af87780)
@guiseek
Copy link
Contributor Author

guiseek commented Dec 3, 2024

LGTM, thanks for your contribution

you're welcome, man

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed merge: squash commits When the PR is merged, a squash and merge should be performed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants