Skip to content

fix(@angular/build): resolve HMR-prefixed files in SSR with Vite #29365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

alan-agius4
Copy link
Collaborator

Improved handling of Angular prefixed files when using Vite dev-server with SSR. Updated logic ensures proper resolution of file:// files paths with query strings.

Closes #29364

Improved handling of Angular prefixed files when using Vite dev-server with SSR. Updated logic ensures proper resolution of `file://` files paths with query strings.

Closes angular#29364
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 16, 2025
@alan-agius4 alan-agius4 merged commit 48385bd into angular:main Jan 16, 2025
32 of 33 checks passed
@alan-agius4 alan-agius4 deleted the ssr-hmr-files branch January 16, 2025 09:42
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR Vite cannot find /@ng/component entry point module in v19.1.0 SSR
2 participants