-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/build): perform incremental background file updates with component updates #29373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/build): perform incremental background file updates with component updates #29373
Conversation
9cb2bc9
to
fa325b2
Compare
… component updates When HMR is enabled, a change to a lazy route component template may alter the names of lazy chunks. These lazy chunks must be updated within the development server so that any later non-HMR based update will have access to these chunks. To support this, the incremental results from the build process can now emit background file updates that will provide output file changes without triggering client updates.
fa325b2
to
fbe97d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am no longer able to replicate the problem with this change.
NIT: as a followup we should add a test that verifies when accessing main.js
vite does not error.
The changes were merged into the following branches: main, 19.1.x |
@alan-agius4 Do you know when the next |
@p1n5u, this update was released last week. I believe you may be encountering a different issue. |
@alan-agius4 you are right. sorry for the noise. will try to create a minimal reproduction example and open an issue. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When HMR is enabled, a change to a lazy route component template may alter the names of lazy chunks. These lazy chunks must be updated within the development server so that any later non-HMR based update will have access to these chunks. To support this, the incremental results from the build process can now emit background file updates that will provide output file changes without triggering client updates.