feat(@angular/cli): add fallback for CSS variables #7514 #7712
Conversation
In order to integrate with CSS frameworks that use the "var" keyword, cssnext needs to be added to the build toolchain to preprocess the CSS rules. This also replaces the need to call autoprefixer directly.
Remove explicit dependency on autoprefixer since postcss-cssnext already includes it. Fix failing test:deps.
Update test:licenses to understand the quirks in the license indicators for dependencies of postcss-cssnext. Fix failing tests.
|
Hmm, tests are randomly failing, I'll poke on my local machine a bit more, but could someone take a look to see if I'm messing up something obvious? |
|
The tests fail differently on my machine due to WebDriver errors. I can't run them cleanly in Windows or in Linux or in the subsystem for Linux on Windows. Most likely I am missing something... |
|
@garoyeri Don't worry about the tests, Angular 4.4.1 broke our travis. We'll look at the PR and restart the tests when it's resolved. Thanks! |
scripts/test-licenses.js
Outdated
| @@ -41,6 +41,7 @@ const acceptedSpdxLicenses = [ | |||
| 'BSD-4-Clause', | |||
| 'CC-BY-3.0', | |||
| 'CC-BY-4.0', | |||
| 'CC0-1.0', | |||
There was a problem hiding this comment.
Unfortunately, we cannot allow CC0 licenses in any Google project. It is not a valid license. I'm looking at why your PR would not work without this whitelisting.
There was a problem hiding this comment.
CC0 is a well-defined dedication of the work to the Public Domain. I would suspect that this would be more accepted than a generically worded Public Domain dedication. One of the parts of postcss-cssnext is a Public Domain component. I would argue it to be similar to "Beerware" or the "Unlicense", although a lot more complete.
The offending packages are:
Here's a link to one license text: https://github.com/jonathantneal/postcss-nesting/blob/master/LICENSE.md
This reverts commit 2d9a3b0. Back out license test changes and package-lock.json.
Using --devkit=/absolute/path/to/devkit/repo the e2e tests will now run with the devkit passed in. It will build the devkit first, then change the package.json to use the proper devkit tgz.
…sion for project now
This depends on angular/devkit#149 Fixes #7695
The issue here is that the sourceDir string could be anywhere in the path. We only care about it if its at the start.
The Spdx list is the list of licenses understood by SPDX, not necessarily agreed on by our team and/or Google. That variable is really a whitelist.
Regenerate package-lock.json after merging up from master.
Ignore license declarations for packages that do not properly note licenses in their package.json files.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Oh yuck. That push didn't look as nice as I'd hoped. I may need to rethink my approach anyway if CC0 is not allowed. The original issue #7514 mentioned the package postcss-custom-properties as an alternative. This is much more favorably licensed it seems (mainly MIT and one BSD-3). I'll submit a separate pull request for that one and close out this one tomorrow. (Unless there's a dramatic change of policy and CC0 is magically acceptable). :) |
|
Reworked and resubmitted as #7770 . Closing this one because it ended up ... dodgy. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In order to integrate with CSS frameworks that use the "var" keyword, cssnext needs to be added to the build toolchain to preprocess the CSS rules. This also replaces the need to call autoprefixer directly.