This repository was archived by the owner on Apr 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Tidy and update repo #123
Closed
Closed
Tidy and update repo #123
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f1587fc
refactor: move e2e test files where protractor expects to find them
gkalpak 0b7f1de
test(e2e): change server port to 9000
gkalpak e3f2142
chore: update dependencies
gkalpak 1b77471
refactor(gulpfile): remove redundant task dependencies
gkalpak 776a306
fix(gulpfile): run on Windows
gkalpak 3a65cf2
feat(package.json): more scripts (no `karma-cli`)
gkalpak 353780d
chore: switch to yarn
gkalpak 46c52df
docs: several updates
gkalpak 3359e6e
test(unit): use latest versions for browsers and `sauce-connect`
gkalpak 1b2f6b7
chore(travis): also test against AngularJS v1.5.x and v1.6.x
gkalpak 1b0a5ce
feat(hint): new version of `hint.js`
gkalpak cc54ff7
test: fix SauceLab config for unit tests and disable e2e tests
gkalpak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ | |
/node_modules/ | ||
/dist/ | ||
/.idea/ | ||
/yarn-error.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,14 +12,7 @@ Please read and follow our [Code of Conduct](https://github.com/angular/code-of- | |
## <a name="issue"></a> Open an Issue | ||
|
||
If you find a bug in AngularHint, you can help us by submitting an issue to our | ||
[GitHub Repository](https://github.com/angular/angular-hint). If you can trace the issue to a specific AngularHint module, please go | ||
to the module's repository to submit the issue. The current repositories for AngularHint modules are: | ||
- [Angular Hint Controllers](https://github.com/angular/angular-hint-controllers) | ||
- [Angular Hint Directives](https://github.com/angular/angular-hint-directives) | ||
- [Angular Hint DOM](https://github.com/angular/angular-hint-dom) | ||
- [Angular Hint Events](https://github.com/angular/angular-hint-events) | ||
- [Angular Hint Interpolation](https://github.com/angular/angular-hint-interpolation) | ||
- [Angular Hint Modules](https://github.com/angular/angular-hint-modules) | ||
[GitHub Repository](https://github.com/angular/angular-hint). | ||
|
||
To help us effectively address your issue, please follow these steps: | ||
1. Use GitHub to search for duplicate issues. If a similar issue already exists, add more | ||
|
@@ -56,33 +49,21 @@ send us a Pull Request. Following these steps will help us to include your code: | |
``` | ||
3. Create your patch, **including appropriate test cases** | ||
4. Follow our [Coding Style Guidelines](#style) | ||
5. Run the AngularHint protractor testing suite using the `gulp` command, or run an AngularHint | ||
module's unit tests using `karma start`. Ensure that all tests pass. | ||
5. Run the AngularHint protractor testing suite using `yarn test-e2e`, or run an AngularHint | ||
module's unit tests using `yarn test-unit`. Ensure that all tests pass. | ||
6. Commit your changes using a descriptive commit message that follows our [commit guidelines](#commit) | ||
|
||
```shell | ||
git commit -a | ||
``` | ||
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files. | ||
7. Build your changes locally to ensure all the tests pass | ||
For AngularHint: | ||
|
||
```shell | ||
gulp | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you no longer need to check in built files? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't changed anything in that regard. But this step is run after you have commited your changes so it is not about including built files in the commit. This step just seemed a duplicate of step 5 (running tests), with extra info about modules, which do not exist any more. (Also note that the default |
||
``` | ||
|
||
For an AngularHint module: | ||
|
||
```shell | ||
karma start | ||
``` | ||
8. Push your branch to GitHub: | ||
7. Push your branch to GitHub: | ||
|
||
```shell | ||
git push origin my-fix-branch | ||
``` | ||
9. In GitHub, send a pull request to AngularHint or the appropriate AngularHint module | ||
10. If we suggest changes then: | ||
8. In GitHub, send a pull request to AngularHint. | ||
9. If we suggest changes then: | ||
- Make the required updates | ||
- Re-run the tests and ensure they are still passing | ||
- Rebase your branch and force push to your GitHub repository (this will update your PR): | ||
|
@@ -91,7 +72,7 @@ send us a Pull Request. Following these steps will help us to include your code: | |
git rebase master -i | ||
git push -f | ||
``` | ||
11. After your pull request is merged you can delete your branch an pull the changes from the | ||
10. After your pull request is merged you can delete your branch an pull the changes from the | ||
main repository. | ||
|
||
- Delete the remote branch: | ||
|
@@ -121,8 +102,7 @@ send us a Pull Request. Following these steps will help us to include your code: | |
|
||
##<a name="style"></a> Coding Style Guidelines | ||
|
||
To help keep the code in AngularHint and the AngularHint modules consistent, please follow | ||
these conventions. | ||
To help keep the code in AngularHint consistent, please follow these conventions. | ||
|
||
###1. AngularHint Guidelines | ||
|
||
|
@@ -138,8 +118,8 @@ send us a Pull Request. Following these steps will help us to include your code: | |
|
||
- All features should be covered by appropriate tests. In AngularHint the e2e tests | ||
are run through protractor and contained in the `e2e` directory. In individual AngularHint | ||
modules the unit tests are run through karma. Check the existing tests in the module you are working | ||
with to see the conventions for that module. | ||
modules the unit tests are run through karma. Check the existing tests in the module you are | ||
working with to see the conventions for that module. | ||
|
||
#### Coding | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess all these repos have been consumed into this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I have no idea what happened to them 😁
I know the repositories do not exist any more (although they used to) and src/modules has some files that seem to correspond to some (although not all) of the modules. So I assume some got merged, some got removed(?).