Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

chore(*): upgrade all dependencies, switch from bower to npm and other improvements #430

Merged
merged 0 commits into from
Nov 15, 2018
Merged

chore(*): upgrade all dependencies, switch from bower to npm and other improvements #430

merged 0 commits into from
Nov 15, 2018
+0 −0

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 20, 2018 •
edited
Loading

Through protractor we transitively depend on a ChromeDriver version that does not support the latest stable Chrome version. Upgrading protractor fixes this. I took the chance to upgrade all dependencies.

I also committed the lockfile that is automatically created by npm install these days, so unfamiliar users won't be left wondering what this new file is all about and what to do with it every time they npm install (or run scripts that do npm install, such as npm test or npm run protractor).

Fixes #429.

Related PR: angular/angular.js#16753

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gkalpak
Copy link
Member Author

gkalpak commented Mar 20, 2018

Basically, 5d33f6d is the new commit. The rest are just rebased on top of that.

petebacondarwin
petebacondarwin approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update the version of node that we run on Travis: https://travis-ci.org/angular/angular-phonecat/builds/355802674#L701

Otherwise LGTM

@gkalpak gkalpak force-pushed the chore-upgrade-deps branch 4 times, most recently from 91e33dc to 02e4f57 Compare March 27, 2018 11:01
@gkalpak
Copy link
Member Author

gkalpak commented Mar 27, 2018 •
edited
Loading

The non-step commits are the new ones (the rest are just step commits rebased on top of the new ones).
In addition to upgrading dependencies, I also removed duplicate work done in scripts/private/*.sh, upgraded Node to the current LTS (10.x) and removed the obsolete update-async-index npm script (which didn't work anyway).

There seems to be some issue with the way tests are run off of branches on CI (I believe the wrong commits are checked out), but I don't have time to look into it right now. I'll try to revisit in a couple of days half a dozen months.

@gkalpak gkalpak mentioned this pull request Apr 7, 2018
Closed
3 tasks
@gkalpak gkalpak force-pushed the chore-upgrade-deps branch 13 times, most recently from e7c2b1a to 2b3a969 Compare November 1, 2018 14:16
@gkalpak
Copy link
Member Author

gkalpak commented Nov 1, 2018 •
edited
Loading

Notes:

@gkalpak gkalpak changed the title chore(package): upgrade all dependencies and commit lockfile chore(*): upgrade all dependencies, switch from bower to npm and other improvements Nov 2, 2018
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Nov 2, 2018
@gkalpak
docs(tutorial): use the angular/angular-phonecat#1.5-snapshot branch

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
fd0939c 
Similar to what was done in 6234cda for the `v1.4.x` branch.
The tutorial will slightly change for v1.7.x (see
angular/angular-phonecat#430 for details), so this commit ensures the
tutorial for older versions (v1.5.x, v1.6.x) remains usable.
@gkalpak gkalpak mentioned this pull request Nov 2, 2018
Closed
@gkalpak gkalpak force-pushed the chore-upgrade-deps branch 2 times, most recently from fdb1d95 to 70fcbc8 Compare November 2, 2018 10:10
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Nov 2, 2018
@gkalpak
docs(tutorial): switch from bower to npm and upgrade AngularJS to…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
fb08285 
… 1.7.x

Related: angular/angular-phonecat#430
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Nov 2, 2018
@gkalpak
docs(tutorial): replace getLocationAbsUrl() with getCurrentUrl()

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
07e72ec 
Protractor's `browser.getLocationAbsUrl()` has been deprecated and
`browser.getCurrentUrl()` is the recommended alternative.
Related: angular/angular-phonecat#430
@gkalpak gkalpak mentioned this pull request Nov 2, 2018
Closed
@gkalpak gkalpak force-pushed the chore-upgrade-deps branch 3 times, most recently from f6b4132 to f15c630 Compare November 5, 2018 12:26
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Nov 5, 2018
@gkalpak
docs(tutorial): switch from bower to npm and upgrade AngularJS to…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
693c8af 
… 1.7.x

Related: angular/angular-phonecat#430
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Nov 5, 2018
@gkalpak
docs(tutorial): replace getLocationAbsUrl() with getCurrentUrl()

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0b71cfd 
Protractor's `browser.getLocationAbsUrl()` has been deprecated and
`browser.getCurrentUrl()` is the recommended alternative.
Related: angular/angular-phonecat#430
@gkalpak gkalpak mentioned this pull request Nov 14, 2018
Closed
3 tasks
@gkalpak gkalpak merged commit f15c630 into angular:master Nov 15, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Nov 15, 2018 •
edited
Loading

Merged as c953da6f9...c9eef4716.

gkalpak added a commit to angular/angular.js that referenced this pull request Nov 15, 2018
@gkalpak
docs(tutorial): switch from bower to npm and upgrade AngularJS to…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b77f058 
… 1.7.x

Related: angular/angular-phonecat#430
gkalpak added a commit to angular/angular.js that referenced this pull request Nov 15, 2018
@gkalpak
docs(tutorial): replace getLocationAbsUrl() with getCurrentUrl()

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
a48c47f 
Protractor's `browser.getLocationAbsUrl()` has been deprecated and
`browser.getCurrentUrl()` is the recommended alternative.
Related: angular/angular-phonecat#430
gkalpak added a commit to angular/angular.js that referenced this pull request Nov 15, 2018
@gkalpak
docs(tutorial): switch from bower to npm and upgrade AngularJS to…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
795398f 
… 1.7.x

Related: angular/angular-phonecat#430
gkalpak added a commit to angular/angular.js that referenced this pull request Nov 15, 2018
@gkalpak
docs(tutorial): replace getLocationAbsUrl() with getCurrentUrl()

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
3e6f49a 
Protractor's `browser.getLocationAbsUrl()` has been deprecated and
`browser.getCurrentUrl()` is the recommended alternative.
Related: angular/angular-phonecat#430
@gkalpak gkalpak deleted the chore-upgrade-deps branch November 15, 2018 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required version of chromedriver is out of date
3 participants
@gkalpak @googlebot @petebacondarwin