This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
chore: update the codebase (e.g. directory layout, file naming etc) #334
Closed
Description
Once/If #341 is merged, it would be a good idea to update the code organization to adhere to latest best practices™ and bring the seed closer to the tutorial (see angular/angular-phonecat#326). E.g.:
- Rename
components/
tocore/
orcommon/
.
Now that "components" means something different, it can be confusing.Rename_test.js
files to.spec.js
.Rename module definitions files to.module.js
.Updatekarma.conf.js
to account for the above changes.Optionally, use components when appropriate.
Activity
refactor(*): rename files and directories to bring in-line with moder…
refactor(*): rename files and directories to bring in-line with moder…
refactor(*): rename files and directories to bring in-line with moder…
gkalpak commentedon Oct 26, 2018
Some of the points above will be addressed in #444.
We won't be making more changes now that AngularJS is in LTS mode.
petebacondarwin commentedon Oct 30, 2018
Core makes it sound like it is part of AngularJS no? I could live with common or shared
gkalpak commentedon Oct 30, 2018
I personally prefer
shared
as well, but I tried to lousely follow the Angular style guide. It suggests having a shared directory/module and a core directory/module.I felt that the type of things we had in
components/
was better suited forcore/
(but happy to move toshared/
instead).petebacondarwin commentedon Oct 30, 2018
I am not going to fight over this one
refactor(*): rename files and directories to bring in-line with moder…