Drop non-compliant Promises/A+ progress/notify on $q

[pocesar]

Makes it really hard to replace $q when using a compliant library, since angular uses progress/notify handlers on core itself.

[lgalfaso]

Would it be possible to know what library are you trying to use? The extra
parameters should be ignored, so more info is needed

[pocesar]

I managed to replace $q with bluebird, and set the scheduler to $rootScope.$applyAsync. I was trying to use $interval but uses notify. Another module included in my project also uses notify from $http.
I implemented the defer method manually, along with when.

        Bluebird.defer = function() {
            var dfd: any = {};

            dfd.promise = new Bluebird(function(_resolve, _reject) {
                dfd.resolve = _resolve;
                dfd.reject = _reject;
                dfd.notify = angular.noop;
            });

            return dfd;
        };

        var bb: any = Bluebird;
        bb.when = Bluebird.resolve.bind(Bluebird);

        var originalAll = Bluebird.all;

        Bluebird.all = function(promises: any|any[]) {

            if (angular.isObject(promises) && !angular.isArray(promises)) {
                return Bluebird.props(promises);
            } else {
                return originalAll.call(Bluebird, promises);
            }

        };

        Bluebird.onPossiblyUnhandledRejection(angular.noop);

        function BluebirdConstructor(cb: any): any {
            if (!(this instanceof Bluebird)) {
                return new Bluebird(cb);
            }
            return Bluebird;
        }

        angular.extend(BluebirdConstructor, Bluebird);

        $provide.decorator('$q', function() {
            return BluebirdConstructor;
        });

        $q.onPossiblyUnhandledRejection(function(err: any) {
            if (__DEBUGGING) {
                $log.error(err);
            }
        });

        Bluebird.setScheduler(function(cb) {
            $rootScope.$applyAsync(cb);
        });

[Rush]

I was hit by this problem as well. @pocesar have you been able to fix $interval. It seems to me I would need to replace the whole service to make it work.

[lgalfaso]

would it be possible to have a plunker that shows the entire problem?

[Agamnentzar]

http://plnkr.co/edit/ITbUfnXOogSdO2r1w52J?p=preview

If you remove 'promise' module from dependencies you can see interval ticking as expected

The problem seems to be $interval depending on promise progress notification that is no longer part of promises

[lgalfaso]

@Agamnentzar thanks for the plunker. I think there should be an easy fix.

[Rush]

btw. a dumb/simplified workaround for $interval needing notify is simply swapping it with a custom one:

  app.config(function($provide) {
    $provide.decorator('$interval', function($delegate, $rootScope) {
      var $newInterval = function(fn, timeout) {
        if(arguments.length !== 2 || typeof fn !== 'function' || typeof timeout !== 'number') {
          return console.error(new Error('custom $interval supports only 2 arguments, Function and timeout'));
        }

        var interval = setInterval(function() {
          $rootScope.$apply(fn);
        }, timeout);

        return interval;
      };

      $newInterval.cancel = function(handle) {
        clearInterval(handle);
      };

      return $newInterval;
    });
  });