Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

linky filter does not handle certain punctuation well #15907

Closed
1 of 3 tasks
ppham27 opened this issue Apr 12, 2017 · 2 comments
Closed
1 of 3 tasks

linky filter does not handle certain punctuation well #15907

ppham27 opened this issue Apr 12, 2017 · 2 comments

Comments

@ppham27
Copy link

ppham27 commented Apr 12, 2017

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (see above))

Current behavior:

Links like (www.example.com): include ): as part of the link when it is punctuation.

Expected / new behavior:

): should not be part of the link.

Minimal reproduction of the problem with instructions:

Type (www.example.com): in the example https://docs.angularjs.org/api/ngSanitize/filter/linky

Angular version: 1.6.4

Browser: [all]

Anything else:

ppham27 added a commit to ppham27/angular.js that referenced this issue Apr 12, 2017
@gkalpak
Copy link
Member

gkalpak commented Apr 12, 2017

Closing as duplicate of #7213.

@gkalpak gkalpak closed this as completed Apr 12, 2017
@gkalpak
Copy link
Member

gkalpak commented Apr 12, 2017

I just realized this something different than #7213. Yet, the main problem is discussed in #7213, which is that linky filter currently disallows certain characters that is should allow (per the spec), but aligning it with the spec would break people's expectations wrt to links in plain text.

There is also #13699, which discusses a more general problem, which is that the RegExp used in linky is pretty broken anyway 😁

I'll keep this closed. Let's move the discussion on #7213 and/or #13699.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants