Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Improve unit testing docs in guide #8220

Closed
Narretz opened this issue Jul 16, 2014 · 4 comments
Closed

Improve unit testing docs in guide #8220

Narretz opened this issue Jul 16, 2014 · 4 comments
Labels
PRs plz! type: docs
Milestone
ng-fixit #1

Comments

@Narretz
Copy link
Contributor

Narretz commented Jul 16, 2014

I think the unit testing part of the guide can be improved in major ways. From a quick glance:

  1. It mostly talks about why unit testing is important, and how DI, separating logic from DOM etc. make code testable. This should be separated from the actual examples.
  2. There's almost no reference to the default angular way of testing, i.e. there's no mention of angular-mocks, no mention of Karma (other than for the preprocessor). Jasmine is introduced in the middle of a paragraph
  3. Other minor things:
@Narretz Narretz added this to the Backlog milestone Jul 16, 2014
@RichardLitt
Copy link
Contributor

I think we talked about the controller syntax in #5076. We agreed to change that for 2.0.

The other stuff certainly needs to be done.

@Narretz
Copy link
Contributor Author

Narretz commented Jul 16, 2014

@RichardLitt with 'old controller syntax', I mean that very recently support for controllers on the window was removed, now they all must be defined in a module. I totally forgot about controller as as the new way.

@RichardLitt
Copy link
Contributor

Ah, cool. Got a link for me to the window ref? I've missed that.

@Narretz
Copy link
Contributor Author

Narretz commented Jul 16, 2014

Here, that's what I mean: 3f2232b My explanation maybe wasn't the best

@btford btford removed the gh: issue label Aug 20, 2014
@IgorMinar IgorMinar modified the milestones: ng-fixit #1, Backlog Nov 22, 2014
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing Guide
3d8aca7 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
@jackfranklin jackfranklin mentioned this issue Nov 22, 2014
Closed
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing guide
e28012c 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing guide
474a629 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing guide
393e4ce 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing guide
0ce7034 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
jackfranklin added a commit to jackfranklin/angular.js that referenced this issue Nov 22, 2014
@jackfranklin
docs(unit testing): improve unit testing guide
89179db 
This commit adds to the unit testing guide:

- add explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- Add more fully featured test examples and add more documentation
  around them, in particular the controller test
- more clearly distinguish between the section on principles of testing
  and actual tutorial on writing a test

This should close angular#8220.
@btford btford closed this as completed in 3109342 Nov 22, 2014
gkalpak pushed a commit to gkalpak/angular.js that referenced this issue Dec 5, 2014
@jackfranklin @gkalpak
docs(guide/unit-testing): improve unit testing guide
14f3660 
This commit adds to the unit testing guide:

- an explicit section on additional libraries: Karma, Jasmine and
  angular-mocks and link to the docs for those projects too. Explain the
  benefit and use case for each of these libaries
- fully featured test examples and add more documentation
  around them, in particular the controller test
- a clear separation between the section on principles of testing
  and the actual tutorial on writing a test

Closes angular#8220
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
PRs plz! type: docs
Projects
None yet
Milestone
ng-fixit #1
Development

Successfully merging a pull request may close this issue.

docs(unit testing): improve unit testing guide jackfranklin/angular.js
4 participants
@IgorMinar @btford @RichardLitt @Narretz