Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(ngMessagesConfig): global configuration of the default value for ngMessages' multiple #11891

Closed
wants to merge 2 commits into from

Conversation

lili21
Copy link

@lili21 lili21 commented May 18, 2015

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@lili21
Copy link
Author

lili21 commented May 18, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Jun 3, 2015

Hi, thanks for the PR. There a few things however that need to be changed before this can be added:

  • app-wide configs should use providers instead of constants
  • the behavior needs tests (e.g. if multiple is set when the config is set)

@gkalpak
Copy link
Member

gkalpak commented Jun 1, 2016

Closing due to lack of response.

@gkalpak gkalpak closed this Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants