Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf($compile): only use document fragments when necessary #12041

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Jun 6, 2015

This mainly just explains the TODO(perf). I'm sure the actual impact is negligible, but will avoid creating fragments in the majority of cases (where only one node is being replaced).

(this is a subset of #9365 that can be done on it's own)

@lgalfaso
Copy link
Contributor

lgalfaso commented Jun 8, 2015

I am not sure about this change. I see that there might be some performance improvements, but it will also break calling parent.children when there is only one element. I see that this is a very edge case, but people might be using this

@jbedard
Copy link
Collaborator Author

jbedard commented Jun 8, 2015

Really it's just for groupScan. Once a node has been replaced I don't think anything is supported on that node? Doesn't mean people don't use it though. I could change this to just update the comment instead?

@jbedard
Copy link
Collaborator Author

jbedard commented Oct 28, 2015

Note that if #12094 merges as is then this PR won't be possible anymore (since #12094 always makes use of the document fragment).

@lgalfaso
Copy link
Contributor

I think it is better to land #12094. Later, if there is a way to remove the document fragment, then I am sure that @jbedard will find a way :)

@petebacondarwin
Copy link
Contributor

Closing in favour of #12094

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants