Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Use require.resolve when possible to avoid hard coded module paths. #13320

Closed
wants to merge 1 commit into from
Closed

Use require.resolve when possible to avoid hard coded module paths. #13320

wants to merge 1 commit into from

Conversation

jdalton
Copy link
Contributor

@jdalton jdalton commented Nov 17, 2015

This PR use require.resolve when possible to avoid hard coded module paths. Avoid issues with npm@3 that dedupes/flattens packages deps.

@petebacondarwin petebacondarwin added this to the 1.6.x milestone Nov 24, 2015
@petebacondarwin
Copy link
Contributor

Thanks @jdalton - looks good (although I have not yet tested. We will merge this in after we release 1.5.0)

@jdalton
Copy link
Contributor Author

jdalton commented Nov 25, 2015

Rock!

@IgorMinar
Copy link
Contributor

this LGTM. @petebacondarwin any reason for not merging this now? Looks pretty harmless.

CI failed, but it looks like a flake. I restarted the build.

@petebacondarwin
Copy link
Contributor

The npm install failed locally for me - on Travis it is using the cached node_modules, which is probably why it passed. Also we need to look at moving Travis to a later version of node (currently 0.10.x).
So I don't want to get into this until after 1.5.0 has been released.

@IgorMinar
Copy link
Contributor

I see. Ok
On Tue, Dec 1, 2015 at 5:19 AM Pete Bacon Darwin [email protected]
wrote:

The npm install failed locally for me - on Travis it is using the cached
node_modules, which is probably why it passed. Also we need to look at
moving Travis to a later version of node (currently 0.10.x).
So I don't want to get into this until after 1.5.0 has been released.


Reply to this email directly or view it on GitHub
#13320 (comment).

@Narretz
Copy link
Contributor

Narretz commented Sep 5, 2016

Landed as 6100f10

@Narretz Narretz closed this Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants