This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($httpBackend): complete the request on timeout #14972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the [timeout attribute](https://xhr.spec.whatwg.org/#the-timeout-attribute) and an XHR request times out, browsers trigger the `timeout` event (and execute the XHR's `ontimeout` callback). Additionally, Safari 9 handles timed-out requests in the same way, even if no `timeout` has been explicitly set on the XHR. In the above cases, `$httpBackend` would fail to capture the XHR's completing (with an error), so the corresponding `$http` promise would never get fulfilled. Fixes angular#14969
gkalpak
added
type: bug
component: $http
frequency: low
needs: review
severity: broken expected use
and removed
cla: yes
labels
|
So all other browser call the onError handler when no onTimeout is specified? |
|
Almost 😃 When no (I didn't test other browsers, but since nobody has complained thus far, I assume most of them follow the behavior of Chrome.) |
|
Ok, I've tested in FF, IE11 and Edge and they all behave like Chrome (i.e. they call ontimeout only when a timeout is set). I was a bit worried about calling event handlers twice, but I don't think that can happen. Otherwise, LGTM |
gkalpak
added a commit
that referenced
this pull request
Aug 8, 2016
When using the [timeout attribute](https://xhr.spec.whatwg.org/#the-timeout-attribute) and an XHR request times out, browsers trigger the `timeout` event (and execute the XHR's `ontimeout` callback). Additionally, Safari 9 handles timed-out requests in the same way, even if no `timeout` has been explicitly set on the XHR. In the above cases, `$httpBackend` would fail to capture the XHR's completing (with an error), so the corresponding `$http` promise would never get fulfilled. Note that using `$http`'s `timeout` configuration option does **not** rely on the XHR's `timeout` property (or its `ontimeout` callback). Fixes #14969 Closes #14972
gkalpak
added a commit
that referenced
this pull request
Aug 8, 2016
When using the [timeout attribute](https://xhr.spec.whatwg.org/#the-timeout-attribute) and an XHR request times out, browsers trigger the `timeout` event (and execute the XHR's `ontimeout` callback). Additionally, Safari 9 handles timed-out requests in the same way, even if no `timeout` has been explicitly set on the XHR. In the above cases, `$httpBackend` would fail to capture the XHR's completing (with an error), so the corresponding `$http` promise would never get fulfilled. Note that using `$http`'s `timeout` configuration option does **not** rely on the XHR's `timeout` property (or its `ontimeout` callback). Fixes #14969 Closes #14972
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
$httpBackendfails to detect a request timeout, when.timeouthas been specified on the XHR (or any timeout in Safari 9).See #14969.
What is the new behavior (if this is a feature change)?
$httpBackenddetects request timeouts.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
[ ] Docs have been added / updated (for bug fixes / features)Other information:
When using the timeout attribute and an XHR request times out, browsers trigger the
timeoutevent (and execute the XHR'sontimeoutcallback). Additionally, Safari 9 handles timed-out requests in the same way, even if notimeouthas been explicitly set on the XHR.In the above cases,
$httpBackendwould fail to capture the XHR's completing (with an error), so the corresponding$httppromise would never get fulfilled.Fixes #14969.