Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore($q): change when to resolve #15442

Closed
wants to merge 1 commit into from
Closed

chore($q): change when to resolve #15442

wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Change $q.when usage to $q.resolve

Note that this doesn't address #13709 fully, but it modifies all meaningful areas where $q.when is being used.

@wesleycho
chore($q): change when to resolve
38c49ff 
- Change `$q.when` usage to `$q.resolve`
@gkalpak
Copy link
Member

gkalpak commented Nov 28, 2016

LGTM

@gkalpak gkalpak self-assigned this Nov 28, 2016
@gkalpak gkalpak closed this in 04cbe1e Nov 28, 2016
gkalpak pushed a commit that referenced this pull request Nov 28, 2016
@wesleycho @gkalpak
refactor($q): replace occurrences of .when() with .resolve()
e31175e 
Related to #13709.

Closes #15442
@wesleycho wesleycho deleted the chore/promise-resolve branch November 28, 2016 14:50
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
@wesleycho @ellimist
refactor($q): replace occurrences of .when() with .resolve()
0b1c2d9 
Related to angular#13709.

Closes angular#15442
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gkalpak gkalpak

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesleycho @gkalpak @googlebot