chore: ignore IntelliJ IDEA module files

[gesellix]

Ignore IntelliJ IDEA modules files in the git repository

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[gesellix]

I just signed the CLA as "Tobias Gesellchen"

[benlesh]

Couldn't you just not add them to git file tracking?

[gesellix]

I wouldn't prefer any tool specific config files in a project like Angular. I only found an entry for the .idea folder, but none for .iml files. In order to not accidentially commit such files in any upcoming commits, I thought adding them to .gitignore would be the best. There wasn't any hint on how to handle IDE specific files, so do you know if it would be ok to add them to git?

[benlesh]

Not really my call. Was the lack of .iml causing you an issue? aren't those usually under the .idea folder?

[gesellix]

Well, I didn't have any actual issue, but I wanted to save me (and others) from accidentially adding such files to the git repo. By default they are created beside the .idea folder, so that I noticed the untracked file. After some experience of destroying a peer's project structure by pushing my personal project config files, I've become cautious for such details.

My impression was that ignoring .iml files would only complete the existing entries, but after you seem to be quite skeptical, I'd like to know what would speak against adding such files to .gitignore?

[benlesh]

Well perhaps I'm just overly cautious? I'm not sure. I'm just a skeptic I
guess.

Maybe it's a bad precedent to account for all of the IDEs people could be
using? What about Visual Studio project files (just trying to think of the
worst example).

I'm just playing "devil's advocate". It's probably a reasonable commit.

On Wed, Dec 4, 2013 at 3:02 PM, Tobias Gesellchen
[email protected]:

Well, I didn't have any actual issue, but I wanted to save me (and others)
from accidentially adding such files to the git repo. By default they are
created beside the .idea folder, so that I noticed the untracked file.
After some experience of destroying a peer's project structure by pushing
my personal project config files, I've become cautious for such details.

My impression was that ignoring .iml files would only complete the
existing entries, but after you seem to be quite skeptical, I'd like to
know what would speak against adding such files to .gitignore?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5273#issuecomment-29839635
.

Ben Lesh
// http://www.benlesh.com
// Twitter: @benlesh http://twitter.com/BenLesh
// Github: blesh https://github.com/blesh

[gesellix]

You might be cautious and I would also prefer a shorter gitignore file, but I also tend to completeness and safety regarding common issues. Visual Studio might still be far away from a common issue for this repo :)

[leifhanack]

My 2 Cents:

.gitignore already contain specific stuff and that is the job of .gitignore so that adding *.iml doesn't seem like a showstopper for me. If it makes life easier, why not?

+1

[benlesh]

I'm indifferent I suppose. heh. Is there a sideways thumb emoji? 👍 👎

[leifhanack]

So indifferent means no, or what should I do to get it in ;)

Maybe we can add *.iml and when there is a strict rule for what's in and what not, we will change .gitignore accordingly.

What do you think?

Regards, Leif

[gesellix]

I would propose Leif's suggestion to add the change for now and probably changing the .gitignore contents when we have clear rules.
Otherwise I wouldn't see any reason to keep this PR opened for an indefinite time.

[sephie]

+1
adding *.iml to .gitignore is needed for those that have the project file in the same directory.

Alternatively, you can specifiy to have the project file in the parent dir in IntelliJ's project settings/setup.

[gesellix]

What shall we do with this PR?

The PR would handle the default, when IntelliJ project files are saved in the project folder, so any manual configuration would also be valid for Eclipse or other IDEs. Since there's already some special stuff in the .gitignore file, I wouldn't expect that the quite popular IntelliJ could be problem.

Maybe another option would be some kind of linting. It could check for the presence of IDE project files, but that would only work after a commit/push, which is too late in my point of view.

Thanks for your feedback!

[caitp]

why not also add .xcodeproj and .sln too? but I don't think it's such a big deal to add this, so why not

[caitp]

If this breaks anything, you'd better not get mad at me for it! :c