-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
It looks like this will return a new array every time the expression is evaluated (I guess we were doing that already)... is that what we want? (serious question, I see pros/cons for both ways) |
I put this up to start the discussion if this is something what we want
Even when we are already creating a new instance of the array every single time, it should be possible to cache the array in case the right hand side and left hand side are constants. |
Adds the operators '..' and '...' that work as range operators. These new operators are only valid within an array declaration and allows the array to be declared as a range. E.g. ```html <div ng-repeat="index in [1...pages.length]">{{index}}</div> ```
+1 |
02dc2aa
to
fd2d6c0
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
this is not going to happen in 1.x, so there is no need to keep this open |
@lgalfaso just out of curiosity - was the implementation too big / difficult / generating too many corner cases or is it about perf considerations? I won't be crying over this one, but it was kind of neat feature so was wondering what were the pbs with it. |
@pkozlowski-opensource just not enough traction to make it into the core (specially when you can get a more flexible approach with filter) |
@lgalfaso yeh, makes sense. |
Adds the operators '..' and '...' that work as range operators. These new operators are only valid within an array declaration and allows the array to be declared as a range. E.g.