-
Notifications
You must be signed in to change notification settings - Fork 339
fix(loader): support v1.6.3+ (and other fixes) #308
Conversation
* @license AngularJS v1.3.0-build.3042+sha.76e57a7 | ||
* (c) 2010-2014 Google, Inc. http://angularjs.org | ||
* @license AngularJS v1.6.4-build.5322+sha.d96e58f | ||
* (c) 2010-2017 Google, Inc. http://angularjs.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this stuff just taken straight from the 1.6.4 loader or is it modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is modified in a couple of places (e.g. minErr
doesn't have access to toDebugString()
so it uses a simpler implementation and there are a couple of other changes (marked with ANGULAR HINT ALTERATION
comments) to support 1.2.x as well.
Maybe it is better to remove the header and leave a comment that it is based on v1.6.4 loader.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(BTW, reviewing with ?w=1
reduces the noise significantly 😃)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized the original comment was about dist/hint.js
. My responses were about loader.js
.
dist/hint.js
includes loader.js
(among othr things).
I had accidentally commited dist/hint.js
and the loader.js
changes on different commits (although the dist/hinst.js
changes are directly affected by the loader.js
changes). I have now amended squashed the two commits into one. Sorry for the confusion 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea where the changes come from but I guess they are generated in some way.
Does Batarang have any tests?
So in my ignorance LGTM.
The hint.js is copied from angular-hint. :) |
Yes, Batarang has some tests, but afaict they are about the DevTools panel, rather than how the extension interacts with AngularJS apps. So, stuff like that would not be caught. |
c369f62
to
e9efcce
Compare
Merged 😁 (Happy to address additional feedback/comments in follow-up PRs.) |
angular.Module#info()
method, necessary in v1.6.3+.Fixes #307.