You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AiyazN25 opened this issue
Oct 25, 2021
· 1 comment
· Fixed by #23831
Assignees
Labels
featureThis issue represents a new feature or feature request rather than a bug or bug fixP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
as shown in the example here: https://developers.google.com/maps/documentation/javascript/infowindows#open , i.e: set shouldFocus to false on the InfoWindowOpenOptions object. But there is no way to do this in the angular/google-maps package. In the package, the wrapper component https://github.com/angular/components/blob/master/src/google-maps/map-info-window/map-info-window.ts , has an open method, which only accepts MapAnchorPoint as its argument type - it doesn't support accepting InfoWindowOpenOptions type. Notice that if you access the underlying google.maps.InfoWindow directly in the wrapper, its open method signature is open(map?: Map | StreetViewPanorama, anchor?: MVCObject): void;
so it also does not support accepting InfoWindowOpenOptions as its argument type. Consequently there is no way to prevent keyboard focus from going to Info Windows when they open.
The feature request here is to allow support for InfoWindowOpenOptions as an argument type in the open method, so that shouldFocus can be set to false.
Use Case
Currently facing an accessibility use case: we enter a value into a field, which triggers the map to re-render and its Info Windows to open. To meet an a11y acceptance criteria, the focus should remain on the field, rather than move to one of the Info Windows opened, so having this feature would enable us to meet the a11y criteria.
The text was updated successfully, but these errors were encountered:
AiyazN25
added
feature
This issue represents a new feature or feature request rather than a bug or bug fix
needs triage
This issue needs to be triaged by the team
labels
Oct 25, 2021
crisbeto
added
has pr
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
and removed
needs triage
This issue needs to be triaged by the team
labels
Oct 26, 2021
…zed (angular#23831)
Allows for the `shouldFocus` flag to be passed when opening the info window.
Fixesangular#23829.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
featureThis issue represents a new feature or feature request rather than a bug or bug fixP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Feature Description
In the Google Maps API, you can prevent the keyboard focus being grabbed by the Info Windows, when they open, by doing something like:
as shown in the example here: https://developers.google.com/maps/documentation/javascript/infowindows#open , i.e: set shouldFocus to false on the InfoWindowOpenOptions object. But there is no way to do this in the angular/google-maps package. In the package, the wrapper component https://github.com/angular/components/blob/master/src/google-maps/map-info-window/map-info-window.ts , has an open method, which only accepts MapAnchorPoint as its argument type - it doesn't support accepting InfoWindowOpenOptions type. Notice that if you access the underlying google.maps.InfoWindow directly in the wrapper, its open method signature is
open(map?: Map | StreetViewPanorama, anchor?: MVCObject): void;
so it also does not support accepting InfoWindowOpenOptions as its argument type. Consequently there is no way to prevent keyboard focus from going to Info Windows when they open.
The feature request here is to allow support for InfoWindowOpenOptions as an argument type in the open method, so that shouldFocus can be set to false.
Use Case
Currently facing an accessibility use case: we enter a value into a field, which triggers the map to re-render and its Info Windows to open. To meet an a11y acceptance criteria, the focus should remain on the field, rather than move to one of the Info Windows opened, so having this feature would enable us to meet the a11y criteria.
The text was updated successfully, but these errors were encountered: