Skip to content

refactor: explicitly set static flag on all queries #15680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2019
Merged

refactor: explicitly set static flag on all queries #15680

merged 1 commit into from
Apr 5, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 1, 2019

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.

This PR resolves FW-1212.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Apr 1, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 1, 2019
@crisbeto crisbeto mentioned this pull request Apr 1, 2019
Merged
jelbourn
jelbourn approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm action: merge The PR is ready for merge by the caretaker and removed P2 The issue is important to a large percentage of users, with a workaround labels Apr 1, 2019
@ngbot
Copy link

ngbot bot commented Apr 1, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

kara
kara reviewed Apr 2, 2019
View reviewed changes
@mmalerba mmalerba added presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged and removed action: merge The PR is ready for merge by the caretaker labels Apr 2, 2019
@crisbeto crisbeto force-pushed the fw-1212 branch 2 times, most recently from 633b753 to bb08489 Compare April 2, 2019 18:16
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 2, 2019
@ngbot
Copy link

ngbot bot commented Apr 2, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending forbidden labels detected: presubmit failures

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Member Author

crisbeto commented Apr 2, 2019

Re-did this one by running Paul's schematic which caught a few cases where queries were supposed to be static. I had to revert a couple of them, because they caused tests to fail.

@jelbourn jelbourn removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 2, 2019
@crisbeto
refactor: explicitly set static flag on all queries
8d57b16 
Explicitly marks all `ViewChild` and `ContentChild` queries so that the timing is consistent for apps using Ivy or ViewEngine.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 4, 2019
@crisbeto
refactor(form-field): explicitly set static flag on all queries
9194ae6 
Continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 4, 2019
@crisbeto
refactor(autocomplete): explicitly set static flag on all queries
0565319 
This is a continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
This was referenced Apr 4, 2019
Merged
Merged
mmalerba pushed a commit that referenced this pull request Apr 4, 2019
@crisbeto @mmalerba
refactor(autocomplete): explicitly set static flag on all queries
379927c 
This is a continuation of #15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
mmalerba pushed a commit that referenced this pull request Apr 4, 2019
@crisbeto @mmalerba
refactor(form-field): explicitly set static flag on all queries
e5b5ca5 
Continuation of #15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
@mmalerba mmalerba merged commit 833d428 into angular:master Apr 5, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 8, 2019
@crisbeto
refactor(autocomplete): explicitly set static flag on all queries
9a4fca5 
This is a continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 8, 2019
@crisbeto
refactor(form-field): explicitly set static flag on all queries
12c046a 
Continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 10, 2019
@crisbeto
refactor(form-field): explicitly set static flag on all queries
2dfa2ae 
Continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 10, 2019
@crisbeto
refactor(form-field): explicitly set static flag on all queries
26ecb8c 
Continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
jelbourn pushed a commit that referenced this pull request Apr 18, 2019
@crisbeto @jelbourn
refactor(form-field): explicitly set static flag on all queries (#15720)
79f8542 
Continuation of #15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
jelbourn pushed a commit that referenced this pull request Apr 18, 2019
@crisbeto @jelbourn
refactor(autocomplete): explicitly set static flag on all queries (#1…
a88d883 
…5721)

This is a continuation of #15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
refactor(form-field): explicitly set static flag on all queries (angu…
2c2a914 
…lar#15720)

Continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
refactor(autocomplete): explicitly set static flag on all queries (an…
b05a864 
…gular#15721)

This is a continuation of angular#15680.

Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara left review comments

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @kara @mmalerba @googlebot