fix(mdc chips) Don't let MDC set aria-checked attribute on option chips #16530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 16, 2019
| // MDC is currently using this method to set aria-checked on choice and filter chips, | ||
| // which in the MDC templates have role="checkbox" and role="radio" respectively. | ||
| // We have role="option" on those chips instead; as such, we do not want aria-checked. | ||
| if (attr === 'aria-checked') { |
There was a problem hiding this comment.
I think this is supposed to be name.
There was a problem hiding this comment.
Whoops, bad copy paste from #16528. Thank you!
vanessanschmitt
force-pushed
the
set-attr
branch
from
7cc65a6 to
728c657
Compare
crisbeto
added
P3
jelbourn
reviewed
Jul 16, 2019
| // MDC is currently using this method to set aria-checked on choice and filter chips, | ||
| // which in the MDC templates have role="checkbox" and role="radio" respectively. | ||
| // We have role="option" on those chips instead, so we do not want aria-checked. | ||
| if (name === 'aria-checked') { |
There was a problem hiding this comment.
Could you file an issue on the MDC repo about this? I would consider it overzealous.
There was a problem hiding this comment.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.