Skip to content

fix(chips): chip list disabled state out of sync when swapping out form group with a disabled one #17993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix(chips): chip list disabled state out of sync when swapping out form group with a disabled one #17993

merged 1 commit into from
Apr 20, 2020

Conversation

crisbeto
Copy link
Member

Related to #17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.

@crisbeto
fix(chips): chip list disabled state out of sync when swapping out fo…
1706dbf 
…rm group with a disabled one

Related to angular#17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 17, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner December 17, 2019 22:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 17, 2019
jelbourn
jelbourn approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 10, 2020
@jelbourn jelbourn merged commit c67337b into angular:master Apr 20, 2020
jelbourn pushed a commit that referenced this pull request Apr 20, 2020
@crisbeto @jelbourn
fix(chips): chip list disabled state out of sync when swapping out fo…
f4bec43 
…rm group with a disabled one (#17993)

Related to #17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.

(cherry picked from commit c67337b)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
fix(chips): chip list disabled state out of sync when swapping out fo…
820b6d8 
…rm group with a disabled one (angular#17993)

Related to angular#17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot