Skip to content

build: fix sass async worker patch causing successful builds to fail #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

build: fix sass async worker patch causing successful builds to fail #18260

merged 1 commit into from
Jan 22, 2020

Conversation

devversion
Copy link
Member

The sass async worker patch seems to cause successful builds to fail.
This is because the @bazel/worker package expects the Promise to
resolve with a boolean (true = good, false failing build).

@devversion
build: fix sass async worker patch causing successful builds to fail
ea93e52 
The sass async worker patch seems to cause successful builds to fail.
This is because the `@bazel/worker` package expects the Promise to
resolve with a boolean (`true` = good, `false` failing build).
@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 22, 2020
@devversion devversion requested a review from a team as a code owner January 22, 2020 20:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 22, 2020
crisbeto
crisbeto approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jan 22, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2020
@jelbourn jelbourn merged commit 3cbc94a into angular:master Jan 22, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: fix sass async worker patch causing successful builds to fail (a…
9b6cbd8 
…ngular#18260)

The sass async worker patch seems to cause successful builds to fail.
This is because the `@bazel/worker` package expects the Promise to
resolve with a boolean (`true` = good, `false` failing build).
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @crisbeto @jelbourn @googlebot