Skip to content

Conversation

jelbourn
Copy link
Member

R: @hansl @kara

This is the first step on the journey to overlays. I'll be doing it in as small of pieces as possible for ease of reviewing. The PR covers adding an overlay element to the DOM and attaching a portal to it. Future PRs will cover styling, sizing, positioning, and helper directives.

@jelbourn jelbourn added this to the alpha.2 milestone Mar 20, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2016

/**
* Service to create Overlays. Overlay are dynamically added pieces of floating UI, meant to be
* used as low-level a building building block for other components. Dialogs, tooltips, menus,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos:
"Overlay are" --> "Overlays are"
"used as low-level a building building block" --> "used as a low-level building block"

@jelbourn jelbourn force-pushed the overlay-skeleton branch 2 times, most recently from 8beb2dd to 9109f7b Compare March 20, 2016 22:03

/**
* Service to create Overlays. Overlays are dynamically added pieces of floating UI, meant to be
* used as a low-level building building block for other components. Dialogs, tooltips, menus,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has "building" twice?

@kara
Copy link
Contributor

kara commented Mar 20, 2016

LGTM, though still has that one typo if you want to fix

@hansl
Copy link
Contributor

hansl commented Mar 21, 2016

@robertmesserle
Copy link
Contributor

That means it’s working. He didn’t update the screenshot.

Sent from my iPhone

On Mar 20, 2016, at 5:15 PM, Hans [email protected] wrote:

@robertmesserle: the e2e is failing on this; https://travis-ci.org/angular/material2/builds/117214613


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@jelbourn
Copy link
Member Author

I did update it. Seems like it fails to get the image.

@robertmesserle
Copy link
Contributor

@jelbourn Ah, my bad - I was looking on my phone earlier and didn't see the screenshot in the changed files. Must've missed it. Anyway, hard to say what is happening, but this is one of the first things that made me want to push for going back to the server idea for screenshots: our method of manually handling git-lfs files is definitely hacky and I wouldn't be surprised if that was the cause.

@robertmesserle
Copy link
Contributor

Also, after looking at the screenshot URL, it's likely the issue I brought up earlier about PR's that live in other people's repos. The URL for your screenshot doesn't match the pattern of other screenshots we've dealt with so far, so manually handling the git-lfs files might not even really be a valid option.

@jelbourn
Copy link
Member Author

@robertmesserle another bullet point for your doc.

@jelbourn jelbourn merged commit f0e1273 into angular:master Mar 22, 2016
@jelbourn jelbourn deleted the overlay-skeleton branch September 13, 2017 04:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants