fix(checkbox): Emit event when checkbox's indeterminate value changes #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 14, 2017
src/lib/checkbox/checkbox.ts
Outdated
| this._transitionCheckState( | ||
| this.checked ? TransitionCheckState.Checked : TransitionCheckState.Unchecked); | ||
| } | ||
| this.indeterminateChange.emit(this._indeterminate); |
There was a problem hiding this comment.
Should this event only fire when the value changes?
src/lib/checkbox/checkbox.ts
Outdated
| @Output() change: EventEmitter<MdCheckboxChange> = new EventEmitter<MdCheckboxChange>(); | ||
|
|
||
| /** Event emitted when the checkbox's `indeterminate` value changes. */ | ||
| @Output() indeterminateChange: EventEmitter<Boolean> = new EventEmitter<Boolean>(); |
tinayuangao
force-pushed
the
fix-checkbox
branch
2 times, most recently
from
35ad57a to
7aea87d
Compare
tinayuangao
force-pushed
the
fix-checkbox
branch
from
7aea87d to
dcfdae0
Compare
|
Comments addressed. Please take another look. Thanks! |
jelbourn
added
pr: lgtm
action: merge
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
…angular#2130) * Emit event when checkbox indeterminate value changes * Add test * Use boolean and emit indeterminate only if value changed
|
when will this change released? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2004
R: @jelbourn