Skip to content

fix(material-experimental/mdc-table): flex tables should stretch cells #23259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jul 28, 2021

Row layout breaks when flex cells have a lot of content - the cell will grow but the row will not because rows have an explicit height. If the explicit height is removed, the row will expand but the other cells do not, causing their borders to be all over the place.

This lets rows grow with the cells, and lets the surrounding cells also grow

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jul 28, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 28, 2021
@andrewseguin andrewseguin requested a review from crisbeto July 29, 2021 15:29
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 29, 2021
@andrewseguin andrewseguin merged commit b17ed9d into angular:master Jul 29, 2021
andrewseguin added a commit that referenced this pull request Jul 29, 2021
andrewseguin added a commit that referenced this pull request Jul 29, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants