Skip to content

docs(cdk/testing): Clean up references to the now deprecated ProtractorHarnessEnvironment #24307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

docs(cdk/testing): Clean up references to the now deprecated ProtractorHarnessEnvironment #24307

merged 2 commits into from
Jan 31, 2022

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Jan 28, 2022
@mmalerba mmalerba requested a review from andrewseguin January 28, 2022 21:48
@mmalerba mmalerba requested review from devversion, jelbourn and a team as code owners January 28, 2022 21:48
jelbourn
jelbourn approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2022
@devversion devversion changed the title docs(cdk/testing): Clean up references to the now deprecated ProtractorHarnessEnvironemnt docs(cdk/testing): Clean up references to the now deprecated ProtractorHarnessEnvironment Jan 29, 2022
@amysorto amysorto merged commit 1f40b7d into angular:master Jan 31, 2022
amysorto pushed a commit that referenced this pull request Jan 31, 2022
@mmalerba @amysorto
docs(cdk/testing): Clean up references to the now deprecated Protract…
d984cce 
…orHarnessEnvironment (#24307)

* docs(cdk/testing): Clean up references to the now deprecated ProtractorHarnessEnvironemnt

* fix(cdk/testing): fix spelling

(cherry picked from commit 1f40b7d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @devversion @amysorto