Skip to content

fix(material/radio): updating required value should mark for check #31109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

fix(material/radio): updating required value should mark for check #31109

merged 1 commit into from
May 21, 2025

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 13, 2025

This change ensures that updates to the required value of the radio button also mark the component for check, ensuring OnPush compatibility.

@atscott
fix(material/radio): updating required value should mark for check
1d4349d 
This change ensures that updates to the required value of the radio
button also mark the component for check, ensuring OnPush compatibility.
@atscott atscott requested a review from a team as a code owner May 13, 2025 21:38
@atscott atscott requested review from crisbeto and andrewseguin and removed request for a team May 13, 2025 21:38
@atscott
Copy link
Contributor Author

atscott commented May 20, 2025 •
edited
Loading

presubmit results

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label May 20, 2025
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label May 21, 2025
@mmalerba mmalerba merged commit fc36e66 into angular:main May 21, 2025
27 of 29 checks passed
@mmalerba
Copy link
Contributor

The changes were merged into the following branches: main, 19.2.x, 20.0.x

mmalerba pushed a commit that referenced this pull request May 21, 2025
@atscott @mmalerba
fix(material/radio): updating required value should mark for check (#…
e5eb939 
…31109)

This change ensures that updates to the required value of the radio
button also mark the component for check, ensuring OnPush compatibility.

(cherry picked from commit fc36e66)
mmalerba pushed a commit that referenced this pull request May 21, 2025
@atscott @mmalerba
fix(material/radio): updating required value should mark for check (#…
bd614b4 
…31109)

This change ensures that updates to the required value of the radio
button also mark the component for check, ensuring OnPush compatibility.

(cherry picked from commit fc36e66)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/radio target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @mmalerba @crisbeto