Skip to content

fix(selection-list): model not updated when option is selected programmatically #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

crisbeto
Copy link
Member

Fixes the list selection model not being updated when an option in the list is selected programmatically.

Fixes #7318.

@crisbeto crisbeto requested a review from jelbourn as a code owner September 26, 2017 15:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 26, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review action: merge The PR is ready for merge by the caretaker labels Sep 26, 2017
…mmatically

Fixes the list selection model not being updated when an option in the list is selected programmatically.

Fixes angular#7318.
@crisbeto crisbeto force-pushed the 7318/selection-list-programmatic branch from d3249f2 to c6c9e3c Compare September 30, 2017 10:25
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Sep 30, 2017
@kara kara merged commit f40a7cc into angular:master Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting selected=true for mat-list-option in mat-selection-list doesn't update selectedOptions.selected
5 participants