fix(button-toggle): allow toggle group elevation to be overwritten #7909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
7264/button-toggle-elevation
branch
2 times, most recently
from
b9c5be7 to
49fba7f
Compare
andrewseguin
added
the
presubmit failures
crisbeto
force-pushed
the
7264/button-toggle-elevation
branch
from
49fba7f to
b283477
Compare
crisbeto
force-pushed
the
7264/button-toggle-elevation
branch
from
b283477 to
0d8345f
Compare
crisbeto
force-pushed
the
7264/button-toggle-elevation
branch
from
0d8345f to
52bbcbb
Compare
Allows for consumer to specify a custom elevation on a `mat-button-toggle-group`. Relates to angular#7264.
crisbeto
force-pushed
the
7264/button-toggle-elevation
branch
from
52bbcbb to
fc5d589
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 4, 2019
…yling applied incorrectly * Fixes not being able to override the elevation of a button toggle. Similar to angular#7909, but makes avoids issues with the new appearance. * Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing. Fixes angular#14721.
|
Closing in favor of #14722. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 27, 2019
…yling applied incorrectly * Fixes not being able to override the elevation of a button toggle. Similar to angular#7909, but makes avoids issues with the new appearance. * Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing. Fixes angular#14721.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for consumer to specify a custom elevation on a
mat-button-toggle-group.Relates to #7264.