Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(mdCompilerProvider): refinements for clarity #11257

Merged
merged 1 commit into from
Apr 25, 2018
Merged

docs(mdCompilerProvider): refinements for clarity #11257

merged 1 commit into from
Apr 25, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Some typos and unclear guidance.

Issue Number:
Relates to #11255.

What is the new behavior?

Address these issues identified in the code review of #11255. Thanks to @mgol and @gkalpak for the review!

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

@Splaktar Splaktar added type: docs pr: merge ready This PR is ready for a caretaker to review g3: reported The issue was reported by an internal or external product team. pr: merge safe labels Apr 25, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 25, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 25, 2018
@Splaktar Splaktar added the P3: important Important issues that really should be fixed when possible. label Apr 25, 2018
@Splaktar Splaktar mentioned this pull request Apr 25, 2018
Merged
3 tasks
mgol
mgol approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewseguin andrewseguin merged commit 039d2fe into master Apr 25, 2018
@Splaktar Splaktar deleted the mdCompilerProviderDocs2 branch April 26, 2018 02:31
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
docs(mdCompilerProvider): refinements for clarity (#11257)
08785d4 
Relates to #11255.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgol mgol mgol approved these changes

Assignees

@andrewseguin andrewseguin

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @mgol @googlebot @andrewseguin