This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Initial implementation of Service Worker testing #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,12 @@ | |||
| }, | |||
| "homepage": "https://github.com/angular/progressive#readme", | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
How about an npm script to build and run e2e tests?
There was a problem hiding this comment.
Will do as part of my Gulp refactor (which I showed you earlier).
…and properly export the type for BroccoliPlugin to allow type definition generation.
…r, including a basic sanity test which verifies that the worker installs correctly.
|
Comments addressed, please rereview @jeffbcross |
jeffbcross
modified the milestones:
Iteration Ending 2016-07-09,
Iteration Ending 2016-06-25
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.