Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Upgrade to Jasmine 3.3.0 #5054

Closed
Closed
Upgrade to Jasmine 3.3.0#5054
Assignees
cnishina
Labels
P2selenium4upgradetype: enhancement
Milestone
 
selenium4 upgrade
@Maximaximum

Description

@Maximaximum
Maximaximum
opened on Nov 23, 2018

Feature Request

It would be great to upgrade to Jasmine 3.3.0.

There's already an issue #4788 and a PR #4842 to upgrade to 3.1.0, but 3.3.0 has some new features including Expectation.withContext() function, which would be a very useful thing for e2e tests.

Activity

cnishina
self-assigned this
on Nov 24, 2018
cnishina
added
type: enhancement
on Nov 24, 2018
cnishina
added this to the selenium4 upgrade milestone on Nov 24, 2018
cnishina
added
selenium4upgrade
on Nov 24, 2018
cnishina

cnishina commented on Nov 24, 2018

@cnishina
cnishina
on Nov 24, 2018
Contributor

I will look into this. I want to use a matching version of Jasmine supported internally as well.

cnishina
added
P2
on Nov 29, 2018
cnishina
added 2 commits that reference this issue on Dec 10, 2018

deps(jasmine): upgrade to the latest jasmine version 3.3

751a493

deps(jasmine): upgrade to the latest jasmine version 3.3

b4f8d75
cnishina
mentioned this on Dec 11, 2018
cnishina
added 5 commits that reference this issue on Dec 12, 2018

deps(jasmine): upgrade to the latest jasmine version 3.3

abf06c9

deps(jasmine): upgrade to the latest jasmine version 3.3

78b96ef

deps(jasmine): upgrade to the latest jasmine version 3.3

00e4cc0

deps(jasmine): upgrade to the latest jasmine version 3.3

0bc272f

deps(jasmine): upgrade to the latest jasmine version 3.3

59deeaf
cnishina

cnishina commented on Dec 13, 2018

@cnishina
cnishina
on Dec 13, 2018
Contributor

Tagging this issue as kinda related: jasmine/jasmine#1522

5 remaining items

cnishina
added a commit that references this issue on Dec 16, 2018

deps(jasmine): upgrade to the latest jasmine version 3.2

5eba77e
cnishina

cnishina commented on Dec 17, 2018

@cnishina
cnishina
on Dec 17, 2018
Contributor

I changed the title of the PR. I think this is the step in the right direction to getting us to 3.3

cnishina

cnishina commented on Dec 19, 2018

@cnishina
cnishina
on Dec 19, 2018
Contributor

Could this fix #3234 ? I have no idea.... fingers crossed. I have two days and a dream to get this done.

cnishina

cnishina commented on Dec 20, 2018

@cnishina
cnishina
on Dec 20, 2018
Contributor

Closed with #5102

cnishina
closed this as completedon Dec 20, 2018
Maximaximum

Maximaximum commented on Dec 21, 2018

@Maximaximum
Maximaximum
on Dec 21, 2018
Author

Cool, thank you!
Looking forward to the new protractor release supporting Jasmine 3.3.0!

daniell0gda

daniell0gda commented on Dec 21, 2018

@daniell0gda
daniell0gda
on Dec 21, 2018

Thanks! Do you have idea when we can use it ?

OrangeDog

OrangeDog commented on Jun 3, 2019

@OrangeDog
OrangeDog
on Jun 3, 2019

What framework are you supposed to use with this? jasmine3 is not a valid framework.

cnishina

cnishina commented on Jun 5, 2019

@cnishina
cnishina
on Jun 5, 2019
Contributor

This PR was to go into the selenium-webdriver 4 upgrade. This is being held back and will be released in coordination with the Angular team. Jasmine 3 I believe is a valid testing framework.

gsai0205

gsai0205 commented on Aug 20, 2019

@gsai0205
gsai0205
on Aug 20, 2019

Looking forward to the new protractor release supporting Jasmine 3.3.0!

danduh

danduh commented on Nov 17, 2019

@danduh
danduh
on Nov 17, 2019

Any updates about supporting Jasmine 3.3.0?

manuman94

manuman94 commented on Apr 17, 2020

@manuman94
manuman94
on Apr 17, 2020

Any updates?

FloMaetschke

FloMaetschke commented on May 11, 2020

@FloMaetschke
FloMaetschke
on May 11, 2020

any updates?

zhe1ka

zhe1ka commented on Jun 24, 2021

@zhe1ka
zhe1ka
on Jun 24, 2021

any updates?

StanislavKharchenko

StanislavKharchenko commented on Jun 24, 2021

@StanislavKharchenko
StanislavKharchenko
on Jun 24, 2021

This depends on the next release of v6-ish.
Related PR #5516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2selenium4upgradetype: enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @OrangeDog@cnishina@danduh@Maximaximum@zhe1ka

      Issue actions
        Upgrade to Jasmine 3.3.0 · Issue #5054 · angular/protractor