Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Move lib/framework JavaScript files to TypeScript #5061

Open
2 of 4 tasks
cnishina opened this issue Nov 28, 2018 · 6 comments
Open
2 of 4 tasks

Move lib/framework JavaScript files to TypeScript #5061

cnishina opened this issue Nov 28, 2018 · 6 comments
Labels
P0 selenium4upgrade type: cleanup
Milestone
selenium4 upgrade

Comments

@cnishina
Copy link
Contributor

cnishina commented Nov 28, 2018 •
edited
Loading

Reference comment: #5059 for file lib/frameworks/debugprint.js

  • lib/frameworks/debugprint.js
  • lib/frameworks/jasmine.js
  • lib/frameworks/mocha.js
  • lib/frameworks/setupAfterEach.js
@cnishina cnishina added this to the selenium4 upgrade milestone Nov 28, 2018
@cnishina cnishina self-assigned this Nov 28, 2018
@cnishina cnishina mentioned this issue Nov 28, 2018
Merged
@cnishina cnishina added the P0 label Nov 29, 2018
@cnishina
Copy link
Contributor Author

cnishina commented Dec 1, 2018

@CrispusDH Do you want to take a stab at this one? It looks pretty straight forward.

@cnishina cnishina removed their assignment Dec 1, 2018
@CrispusDH
Copy link
Contributor

@cnishina , yep I will grab it :)

This was referenced Dec 1, 2018
Merged
Closed
@cnishina
Copy link
Contributor Author

@CrispusDH Could you also take on the setupAfterEach and mocha?

@CrispusDH
Copy link
Contributor

@cnishina , yep. I think it will be done before NY )

@cnishina
Copy link
Contributor Author

Take your time. I'm off for the holidays and won't check back in till 2019.

This was referenced Dec 28, 2018
Closed
Closed
@CrispusDH
Copy link
Contributor

CrispusDH commented Jan 13, 2019 •
edited
Loading

@cnishina I have referenced latest two PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P0 selenium4upgrade type: cleanup
Projects
None yet
Milestone
selenium4 upgrade
Development

No branches or pull requests
2 participants
@cnishina @CrispusDH