This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(tslint): add tslint to gulpfile #3833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
tslint
branch
2 times, most recently
from
77a4df0 to
baf4d66
Compare
|
As part of this, could you put the tslint check on Circle? And please move the format check along with tslint down to the test phase, so they won't block testing if they fail. Thanks! |
cnishina
force-pushed
the
tslint
branch
5 times, most recently
from
9e9af43 to
39705bd
Compare
- add gulp task tslint and lint - update `**/*.ts` with tslint fixes - update circle.yml to run `gulp lint` - update `gulp pretest` to run both jshint and tslint
heathkit
suggested changes
Dec 20, 2016
| @@ -12,7 +12,7 @@ dependencies: | |||
| cache_directories: | |||
| - testapp/node_modules | |||
| post: | |||
| - ./node_modules/.bin/gulp format:enforce | |||
| - ./node_modules/.bin/gulp lint | |||
There was a problem hiding this comment.
I think we still need the format check too, right? Also, let's move this down to before npm test so lint failures don't block test runs.
There was a problem hiding this comment.
I've added the format enforce into the lint similar to blocking-proxy. I also would rather have the test fail immediately if lint / format has errors.
heathkit
approved these changes
Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**/*.tswith tslint fixesgulp lintgulp pretestto run both jshint and tslint