This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Changes "Angular" to "Angular 2" #4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean that Angular 4 DOES support the binding and model locators? |
|
Oh, my bad, I didn't take a look at the whole file. It has already mentioned "angular" in the first section. We should make it consistent in the whole page. |
|
I was not aware of the distinction between Angular and AngularJS. I had just assumed the removal of the 2 was accidental. |
|
ok. so I will rollback this change. |
|
Happy to help! |
qiyigg
added a commit
to qiyigg/protractor
that referenced
this pull request
Feb 13, 2018
This reverts commit 9027274.
qiyigg
added a commit
that referenced
this pull request
Feb 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the Readme deleted wording that said
Angular 2. It makes it sound like no version of Angular will support thebindingandmodellocators, which is not true. We should re-add the "2" back to make this more clear.Diff that introduced the issue: af6afa6#diff-04c6e90faac2675aa89e2176d2eec7d8