chore(test): move element_spec.js off of the control flow #4997

cnishina · 2018-11-06T21:03:32Z

For the basicConf test suite:

Only run the element_spec test in the Protractor config, we will add
back other specs as we migrate the basicConf off of the control
flow.
In the Protractor configuration file, set SELENIUM_PROMISE_MANAGER to false.
Refactor to use async / await.
Refactor var to use either const or let.

cnishina · 2018-11-06T21:09:04Z

Reference #4995

spec/basic/elements_spec.js

heathkit

Let's port these to TS to make them a bit easier to work with.

You can use the no-floating-promises TSLint rule (https://palantir.github.io/tslint/rules/no-floating-promises/) to make sure everything is awaited.

heathkit · 2018-11-06T21:29:22Z

spec/basic/elements_spec.js


-    usernameInput.clear().sendKeys('Jane');
-    expect(name.getText()).toEqual('Jane');
+    await usernameInput.clear().sendKeys('Jane');


What does usernameInput.clear() return? I'm suprised it's not a promise you need to await

Hmmm... For some reason I thought I could still chain these together. I guess not?

I split these up but they should stay together. You should be able to chain these together.

spec/basic/elements_spec.js

cnishina · 2018-11-07T00:59:15Z

So far it looks like starting up webdriver-manager + circleci is flaky. I am also removing all the tests to try to pass only my test.

CrispusDH · 2018-11-07T13:46:50Z

@cnishina could you take a look at my PR - #4998 . I did the same. It was easier to make own PR with it, than make a bunch of comments here. Thanks for your attention. You can just copy paste from element_spec.js and close my PR if you want. I just want to help to reach protractor with selenium 4

Update circleci to support async await. For the basicConf test suite: - Only run the element_spec test in the Protractor config, we will add back other specs as we migrate the basicConf off of the control flow. - In the Protractor configuration file, set `SELENIUM_PROMISE_MANAGER` to false. - Refactor to use async / await. - Refactor `var` to use either `const` or `let`.

heathkit · 2018-11-07T18:43:19Z

First step on the journey to Selenium 4!

cnishina · 2018-11-07T18:46:29Z

So why were these tests failing? I forgot maybe 4-ish await statements. I made all the changes to remove all .then calls. Thanks @CrispusDH I found a diff that helped me out.

Why did Travis fail? Node 6 does not support async / await.

googlebot added cla: yes labels Nov 6, 2018

cnishina changed the title ~~chore(test): move test suite off of the control flow~~ chore(test): move element_spec.js off of the control flow Nov 6, 2018

cnishina force-pushed the you_made_me_promises_promises branch from cb4a7d7 to 99d8192 Compare November 6, 2018 21:13

cnishina requested review from juliemr and heathkit November 6, 2018 21:14