chore(test): move element_spec off of the control flow

circle.yml

@@ -2,71 +2,65 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/node:6.14-browsers
-        environment:
-          # Fix issue with selenium-server in containers.
-          # See http://github.com/SeleniumHQ/docker-selenium/issues/87
-          DBUS_SESSION_BUS_ADDRESS: /dev/null
+    - image: circleci/node:10.13-browsers
+      environment:
+        # Fix issue with selenium-server in containers.
+        # See http://github.com/SeleniumHQ/docker-selenium/issues/87
+        DBUS_SESSION_BUS_ADDRESS: /dev/null
     steps:
-      - checkout
+    - checkout
 
-      - run:
-          name: Install Dependencies
-          command: |
-            sudo apt-get update
-            sudo apt-get install python-pip tcpdump
+    - run:
+        name: Install Dependencies
+        command: |
+          sudo apt-get update
+          sudo apt-get install python-pip tcpdump
+          # Have to update firefox, default is ESR.
+          sudo pip install --upgrade pip
+          sudo pip install mozdownload mozinstall
+          mozdownload --version latest --destination firefox.tar.bz2
+          mozinstall firefox.tar.bz2
+          sudo cp -R firefox/* /opt/firefox/
+          # Latest chrome is already installed in the default container.
+          # curl -L -o google-chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+          # sudo dpkg -i google-chrome.deb
+          # sudo sed -i 's|HERE/chrome\"|HERE/chrome\" --disable-setuid-sandbox|g' /opt/google/chrome/google-chrome
+          # rm google-chrome.deb
+    - restore_cache:
+        key: node_modules-{{ .Branch }}-{{ checksum "package-lock.json" }}
 
-            # Have to update firefox, default is ESR.
-            sudo pip install --upgrade pip
-            sudo pip install mozdownload mozinstall
-            mozdownload --version latest --destination firefox.tar.bz2
-            mozinstall firefox.tar.bz2
-            sudo cp -R firefox/* /opt/firefox/
+    - run:
+        name: NPM Install
+        command: |
+          npm i
+          cd testapp && npm i
+    - save_cache:
+        key: node_modules-{{ .Branch }}-{{ checksum "package-lock.json" }}
+        paths:
+        - "node_modules"
+        - "testapp/node_modules"
 
-            # Latest chrome is already installed in the default container.
-            # curl -L -o google-chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
-            # sudo dpkg -i google-chrome.deb
-            # sudo sed -i 's|HERE/chrome\"|HERE/chrome\" --disable-setuid-sandbox|g' /opt/google/chrome/google-chrome
-            # rm google-chrome.deb
+    - run:
+        name: Lint
+        command: ./node_modules/.bin/gulp lint
 
-      - restore_cache:
-          key: node_modules-{{ .Branch }}-{{ checksum "package-lock.json" }}
+    - run:
+        name: Selenium Start
+        background: true
+        command: |
+          ./node_modules/.bin/webdriver-manager-replacement update --gecko false
+          ./node_modules/.bin/webdriver-manager-replacement start --gecko false
+    - run:
+        name: TestApp Start
+        background: true
+        command: |
+          npm start
+    # Seems like the new circleci container no longer permits packet introspection on lo, even for root.
+    # - run:
+    #    name: Extra tcp logging for BlockingProxy
+    #    background: true
+    #    command: sudo tcpdump -i lo 'tcp && dst localhost' -w $CIRCLE_ARTIFACTS/localdump.pcap
 
-      - run:
-          name: NPM Install
-          command: |
-            npm i
-            cd testapp && npm i
-
-      - save_cache:
-          key: node_modules-{{ .Branch }}-{{ checksum "package-lock.json" }}
-          paths:
-            - "node_modules"
-            - "testapp/node_modules"
-
-      - run:
-          name: Lint
-          command: ./node_modules/.bin/gulp lint
-
-      - run:
-          name: Selenium Start
-          background: true
-          command: |
-            ./node_modules/.bin/webdriver-manager update
-            ./node_modules/.bin/webdriver-manager start
-
-      - run:
-          name: TestApp Start
-          background: true
-          command: |
-            npm start
-
-      # Seems like the new circleci container no longer permits packet introspection on lo, even for root.
-      # - run:
-      #    name: Extra tcp logging for BlockingProxy
-      #    background: true
-      #    command: sudo tcpdump -i lo 'tcp && dst localhost' -w $CIRCLE_ARTIFACTS/localdump.pcap
-
-      - run:
-          name: Test
-          command: npm test
+    - run:
+        name: Test
+        command: npm test