Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

chore(test): use native promises instead of q onCleanUp #5004

Merged
merged 1 commit into from
Nov 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions scripts/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ var passingTests = [
'node built/cli.js spec/basicConf.js',
// 'node built/cli.js spec/basicConf.js --useBlockingProxy',
'node built/cli.js spec/multiConf.js',
// 'node built/cli.js spec/altRootConf.js',
// 'node built/cli.js spec/inferRootConf.js',
// 'node built/cli.js spec/multiConf.js',
'node built/cli.js spec/altRootConf.js',
'node built/cli.js spec/inferRootConf.js',
// 'node built/cli.js spec/onCleanUpAsyncReturnValueConf.js',
// 'node built/cli.js spec/onCleanUpNoReturnValueConf.js',
// 'node built/cli.js spec/onCleanUpSyncReturnValueConf.js',
'node built/cli.js spec/onCleanUpAsyncReturnValueConf.js',
'node built/cli.js spec/onCleanUpNoReturnValueConf.js',
'node built/cli.js spec/onCleanUpSyncReturnValueConf.js',
'node built/cli.js spec/onPrepareConf.js',
'node built/cli.js spec/onPrepareFileConf.js',
'node built/cli.js spec/onPreparePromiseConf.js',
Expand Down
4 changes: 2 additions & 2 deletions spec/onCleanUp/onCleanUp_spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
describe('onCleanUp function in the config', function() {
it('should not be affected by tests', function() {
describe('onCleanUp function in the config', () => {
it('should not be affected by tests', () => {
expect(true).toBe(true);
});
});
14 changes: 6 additions & 8 deletions spec/onCleanUpAsyncReturnValueConf.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
var env = require('./environment.js');
var q = require('q');
const env = require('./environment.js');

// Test that onCleanUp actions are performed.
exports.config = {
mockSelenium: true,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

Expand All @@ -15,11 +15,9 @@ exports.config = {

baseUrl: env.baseUrl + '/ng1/',

onCleanUp: function(exitCode) {
var deferred = q.defer();
setTimeout(function() {
deferred.resolve(exitCode);
}, 500);
return deferred.promise;
onCleanUp: async(exitCode) => {
return await new Promise(resolve => {
setTimeout(resolve(exitCode), 500);
});
}
};
5 changes: 3 additions & 2 deletions spec/onCleanUpNoReturnValueConf.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
var env = require('./environment.js');
const env = require('./environment.js');

// Test that onCleanUp actions are performed.
exports.config = {
mockSelenium: true,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

Expand All @@ -14,7 +15,7 @@ exports.config = {

baseUrl: env.baseUrl + '/ng1/',

onCleanUp: function(/* exitCode */) {
onCleanUp: (/* exitCode */) => {
// no return
}
};
5 changes: 3 additions & 2 deletions spec/onCleanUpSyncReturnValueConf.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
var env = require('./environment.js');
const env = require('./environment.js');

// Test that onCleanUp actions are performed.
exports.config = {
mockSelenium: true,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

Expand All @@ -14,7 +15,7 @@ exports.config = {

baseUrl: env.baseUrl + '/ng1/',

onCleanUp: function(exitCode) {
onCleanUp: (exitCode) => {
return exitCode;
}
};