-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(test): move expected_conditions_spec.js off of the control flow #5006
Conversation
@cnishina , could you take a look at this PR, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of similar issues. Should be a pretty easy fix.
@@ -61,7 +61,7 @@ var executor = new Executor(); | |||
|
|||
passingTests.forEach(function(passing_test) { | |||
executor.addCommandlineTest(passing_test) | |||
.assertExitCodeOnly(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird spacing issue. Let's revert this part for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried copy paste from origin but still has this weird space. I think it could be tab space
thing. Maybe later I will make PR with ESLint that will be responsible with that kind of things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want I can create a new PR where it issue will not be
…actor into expected_conditions_spec
…actor into expected_conditions_spec
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Doh. I deleted an entire file. :( Hrrrmmm... |
Hmmm.... I also appear to have affected the cla. Darn it. Could you close this PR, open up a new one and try to not add a space in that test.js file? Thanks! |
Yeah, other than that, the files lgtm. |
expected_conditions_spec
cripts/test.js