This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): clean up mocha tests #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference #4995. |
heathkit
approved these changes
Nov 8, 2018
- this.slow does not appear to be part of the mocha framework or we are not correctly exposing it. Removed since it was causing errors. - moved tests to be async / await where appropriate.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
- this.slow works only if we use `function` and not a fat arrow. - moved tests to be async / await where appropriate.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
- this.slow works only if we use `function` and not a fat arrow. - moved tests to be async / await where appropriate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not correctly exposing it. Removed since it was causing errors.