This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): clean up no control flow typescript tests #5023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathkit
approved these changes
Nov 9, 2018
| await browser.get('index.html#/form'); | ||
|
|
||
| const usernameInput = element(by.model('username')); | ||
| const name = element(by.binding('username')); | ||
|
|
||
| await expect(name.getText()).toEqual('Anon'); | ||
| expect(await name.getText()).toEqual('Anon'); | ||
|
|
||
| await((usernameInput.clear() as any) as ElementFinder).sendKeys('Jane'); |
There was a problem hiding this comment.
wat? Can't this at least be (usernameInput.clear() as ElementFinder)
There was a problem hiding this comment.
Yes. wat is right. I might need to fix this.
There was a problem hiding this comment.
Casting it just directly to ElementFinder does not work as shown above. Per the documentation, the return type is webdriver.promise.Promise.<void> so I'm not sure how this actually works. Shouldn't it return a promise for an ElementFinder? That would make more sense.
There was a problem hiding this comment.
Oh right, yeah it should be as Promise<ElementFinder>
There was a problem hiding this comment.
I added a TODO to fix this and it is logged as an issue.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.