This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): remove jasmine addMatcher test #5072
Merged
+0
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathkit
suggested changes
Dec 1, 2018
- Removing the addMatchers test since we no longer support async calls resolve with jasminewd since we removed jasminewd. Also Jasmine does not appear to support async calls in custom expectations or the compare method.
cnishina
force-pushed
the
cleanup_locators
branch
from
0f8778f to
adc9e32
Compare
cnishina
changed the title
|
Removed the test. |
heathkit
approved these changes
Dec 3, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
- Removing the addMatchers test since we no longer support async calls resolve with jasminewd since we removed jasminewd. Also Jasmine does not appear to support async calls in custom expectations or the compare method.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
- Removing the addMatchers test since we no longer support async calls resolve with jasminewd since we removed jasminewd. Also Jasmine does not appear to support async calls in custom expectations or the compare method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the addMatchers test since we no longer support async calls
resolve with jasminewd since we removed jasminewd. Also Jasmine does
not appear to support async calls in custom expectations or the
compare method.