Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

refactor: remove angular2- prefix #295

Merged
merged 5 commits into from
Feb 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ test/coverage

/modules/universal/browser/typings
/modules/universal/server/typings
/modules/universal/node/typings
/modules/**/dist
/modules/**/node_modules
/modules/**/typings
/modules/angular2-grunt-prerender/tasks
/modules/grunt-prerender/tasks

8 changes: 2 additions & 6 deletions examples/app/server/express/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,17 @@ var path = require('path');

module.exports = function(ROOT) {
var app = express();
var {ng2ExpressEngine} = require('angular2-universal-preview');
var {expressEngine} = require('angular2-universal-preview');
// rendering engine

app.engine('ng2.html', ng2ExpressEngine);
app.engine('ng2.html', expressEngine);
app.set('views', path.join(ROOT, 'examples'));
app.set('view engine', 'ng2.html');
app.set('view options', { doctype: 'html' });

console.log(__dirname);

var routes = require('./routes');
var api = require('./api');
var graphApi = require('./graph_api');


app.use(serveStatic(`${ROOT}/dist`));
app.use(serveStatic(`${ROOT}/examples/app/public`));

Expand Down
34 changes: 10 additions & 24 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,10 @@
var SERVER_IP = '127.0.0.1';

var port = process.env.PORT || 3000;
// var ssl = process.env.SSLPORT || 4000;

// Module dependencies
var http = require('http');
// require('nocycle').detect();
// var https = require('https');

/*
var options = {
key: fs.readFileSync('/private/etc/apache2/ssl/ssl.key'),
cert: fs.readFileSync('/private/etc/apache2/ssl/ssl.crt')
};
*/

// Start server
var framework = process.argv[2] || 'express';
Expand All @@ -28,11 +19,12 @@ if (framework === 'hapi') {
port,
address: SERVER_IP
});
module.exports.Server = server.start(() => {
console.log(`Listening on port: ${port}`);
// for smoke testing
// smokeTest();
});
module.exports.Server = server
.start(() => {
console.log(`Listening on port: ${port}`);
// for smoke testing
// smokeTest();
});

} else {
// express or other express compliant frameworks
Expand All @@ -45,22 +37,16 @@ if (framework === 'hapi') {
process.exit(1);
}

module.exports.Server = http.createServer(server).listen(port, SERVER_IP,
function() {
module.exports.Server = http
.createServer(server)
.listen(port, SERVER_IP, function() {
console.log(`Listening on port: ${port}`);
// for smoke testing
// smokeTest();
});

}
console.log(`Using framework: ${framework}`);


/*
https.createServer(options, server).listen(ssl, function() {
console.log('Listening on port: ' + ssl + ' in ' + process.env.NODE_ENV);
});
*/
console.log(`Using framework: "${framework}"`);


function smokeTest() {
Expand Down
4 changes: 0 additions & 4 deletions modules/angular2-gulp-prerender/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,19 @@ export function expressEngine(filePath: string, options: engineOptions, done: Fu
}
};

export const ng2engine = function(...args) {
console.warn('DEPRECATION WARNING: `ng2engine` is no longer supported and will be removed in next release. use `expressEngine`');
return expressEngine(...args);
}
export const ng2Engine = function(...args) {
console.warn('DEPRECATION WARNING: `ng2Engine` is no longer supported and will be removed in next release. use `expressEngine`');
return expressEngine(...args);
}
export const ng2ExpressEngine = function(...args) {
console.warn('DEPRECATION WARNING: `ng2ExpressEngine` is no longer supported and will be removed in next release. use `expressEngine`');
return expressEngine(...args);
}

export function simpleReplace(filePath: string, options: engineOptions, done: Function) {
// defaults
options = options || <engineOptions>{};
Expand Down
4 changes: 4 additions & 0 deletions modules/gulp-prerender/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import * as Prerender from './src/prerender';

export * from './src/prerender';
export default Prerender;
12 changes: 6 additions & 6 deletions modules/universal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"typescript": {
"definition": "universal.d.ts"
},
"version": "0.55.4",
"version": "0.60.0",
"description": "Universal (isomorphic) javascript support for Angular2",
"homepage": "https://github.com/angular/universal",
"license": "MIT",
Expand All @@ -35,8 +35,8 @@
"url": "https://github.com/angular/universal/issues"
},
"devDependencies": {
"angular2-express-engine": "file:../angular2-express-engine",
"angular2-hapi-engine": "file:../angular2-hapi-engine",
"angular2-express-engine": "file:../express-engine",
"angular2-hapi-engine": "file:../hapi-engine",
"preboot": "file:../preboot",
"typescript": "^1.7.3"
},
Expand All @@ -51,10 +51,10 @@
"preboot": "~1.1.0",
"angular2-express-engine": "*",
"angular2-hapi-engine": "*",
"rxjs": "~5.0.0-beta.0",
"angular2": "2.0.0-beta.1 - 2.0.0-beta.7",
"rxjs": "~5.0.0-beta.2",
"angular2": "2.0.0-beta.7",
"es6-shim": "^0.33.3",
"zone.js": "0.5.10 - 0.5.15",
"zone.js": "~0.5.15",
"css": "^2.2.1",
"parse5": "^1.5.0"
}
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"remove-ng2-types": "rimraf node_modules/angular2/typings node_modules/angular2/bundles/typings node_modules/angular2/manual_typings node_modules/angular2/ts/manual_typings node_modules/angular2/ts/typings",
"remove-dist": "rimraf dist modules/**/dist !node_modules/**/*",
"remove-tsd-typing": "rimraf ./tsd_typings",
"remove-local-modules": "rimraf node_modules/preboot node_modules/angular2-universal-preview node_modules/angular2-universal node_modules/angular2-express-engine",
"remove-local-modules": "rimraf node_modules/preboot node_modules/angular2-universal-preview node_modules/angular2-universal node_modules/angular2-express-engine node_modules/angular2-hapi-engine",
"update": "npm run remove-local-modules && npm install",
"tsd": "tsd reinstall && tsd link",
"postinstall": "npm run tsd && npm run remove-ng2-types && npm run build && npm run webdriver-update"
Expand Down Expand Up @@ -92,10 +92,11 @@
},
"dependencies": {
"angular2": "2.0.0-beta.7",
"angular2-express-engine": "file:modules/angular2-express-engine",
"angular2-hapi-engine": "file:modules/angular2-hapi-engine",
"angular2-express-engine": "file:modules/express-engine",
"angular2-hapi-engine": "file:modules/hapi-engine",
"angular2-universal": "file:modules/universal",
"angular2-universal-preview": "file:modules/universal",
"preboot": "file:modules/preboot",
"browserify": "^11.0.0",
"css": "^2.2.1",
"es6-shim": "^0.33.8",
Expand All @@ -109,7 +110,6 @@
"lodash": "^3.10.1",
"nocycle": "^1.1.1",
"parse5": "^1.5.0",
"preboot": "file:modules/preboot",
"q": "^1.4.1",
"reflect-metadata": "0.1.2",
"require-dir": "^0.3.0",
Expand Down
16 changes: 8 additions & 8 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
"node_modules/angular2/typings",
"node_modules/angular2/manual_typings",
"node_modules/angular2/bundles/typings",
"modules/angular2-express-engine/dist",
"modules/angular2-express-engine/node_modules",
"modules/angular2-gulp-prerender/node_modules",
"modules/angular2-gulp-prerender/dist",
"modules/angular2-grunt-prerender/node_modules",
"modules/angular2-grunt-prerender/tasks",
"modules/angular2-webpack-prerender/node_modules",
"modules/angular2-webpack-prerender/dist",
"modules/express-engine/dist",
"modules/express-engine/node_modules",
"modules/gulp-prerender/node_modules",
"modules/gulp-prerender/dist",
"modules/grunt-prerender/node_modules",
"modules/grunt-prerender/tasks",
"modules/webpack-prerender/node_modules",
"modules/webpack-prerender/dist",
"modules/universal/dist",
"modules/universal/node_modules",
"modules/preboot/dist",
Expand Down