fix(node-document): create conditional for non html component #614
Conversation
|
So is this one not helpful to fix the bigger issue (with Core handling the head title meta properties itself?) |
|
|
||
|
|
||
| /* | ||
| // Build entire doc <!doctype><html> etc | ||
| if (documentHtml.indexOf('<html>') > -1 && documentHtml.indexOf('</html>') > -1) { |
There was a problem hiding this comment.
this is still a problem with html tags that have attributes like <html ⚡> or <html lang="en">
There was a problem hiding this comment.
Totally right. Should I clean it up to test for just <html, maybe even look for doctype as well? @gdi2290
There was a problem hiding this comment.
you can use a regexp looking for any case of doctype
|
might be supported in ng4 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #347