feat(socket-engine): introduce package

[Toxicable]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Feature

[vikerman]

nit: As long

[vikerman]

This example makes it appear as if there is only one message sent per createConnection with id of 1.

Maybe separate out the connection from sending the request?

[bbortt]

Hi all

I've been playing around with the socket-engine a bit and noticed an in my opinion significant error. My setup: Connect to the socket from an Apache Tomcat container. I am honestly new to sockets and followed this guide, ended up something like this.

WebSocketClient simpleWebSocketClient = new StandardWebSocketClient();
List<Transport> transports = new ArrayList<>(1);
transports.add(new WebSocketTransport(simpleWebSocketClient));
SockJsClient sockJsClient = new SockJsClient(transports);

WebSocketStompClient stompClient = new WebSocketStompClient(sockJsClient);
stompClient.setMessageConverter(new MappingJackson2MessageConverter());

String url = "ws://localhost:9090/";
StompSessionHandler sessionHandler = new MyStompSessionHandler();
StompSession session = stompClient.connect(url, sessionHandler).get();

Now the problem is in the implementation of the Apache org.apache.tomcat.websocket.WsWebSocketContainer.java which sends some default parameters on the initial request. You can see the connect statement and it's unskippable parameters in this file on lines 266 to 275.

So here we are now, sending an initial request to the websocket. An informational request which is not in JSON format. This line tries to parse it - and dos not return an error -> The connection attempt ends in a timeout and the webapplication failes to start!

As far as I see you should cover this line by a try-catch too and handle errors in a maner way?

I'd like to state out once more that this is just what I noticed in a brief test. Also I'm not an Apache pro, just looked into the source code and didn't see a way to skip the initial request (except writing my own implementation, which is maybe a bit too overkill). Just wanted to let you know what I detected. It may be intentional that this line isn't covered by a try-catch, it may not. Up to you.

Cheers

[Toxicable]

That inital request is actually setting up the WS conenction.

// Create the initial HTTP request to open the WebSocket connection

A WebSocket connection starts out as a normal Http connection and once it figures out that both the client and server support WS it's Upgraded to a WS connection, this is what that inital connection is doing.

HOWEVER; We are not using WebSockets here.

We are using raw TCP Sockets, meaning, no http, no WS, only a raw TCP Socket.
I don't know what it's called in Java but it isn't WebSockets

[bbortt]

Oh that's the thing. Sorry and thank you for the explanation.

[Toxicable]

remove this

[Toxicable]

resolve this

[Toxicable]

ran into some other issues with this change, will nbeed a full set of updates later

[CaerusKaru]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}